Closed
Bug 744052
Opened 11 years ago
Closed 11 years ago
Restructure HashTable::checkOverflow for easier reading
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
In which :terrence reads what he wrote two weeks ago... When I added this function, I just copied the existing logical structure. It makes more sense here to check overflowed and return early, since we can do this now.
Attachment #613649 -
Flags: review?(luke)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 613649 [details] [diff] [review] v0 Much nicer
Attachment #613649 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/38f159e04083
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38f159e04083
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•