Closed
Bug 744157
Opened 8 years ago
Closed 8 years ago
Return nsICSSDeclaration from Element::GetSMILOverrideStyle
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Not set
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: jhk)
References
Details
(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])
Attachments
(1 file)
5.28 KB,
patch
|
dholbert
:
review+
Ms2ger
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•8 years ago
|
||
See <http://mxr.mozilla.org/mozilla-central/ident?i=GetSMILOverrideStyle&filter=>. The GetSMILOverrideStyle() function should return nsICSSDeclaration* instead of nsIDOMCSSStyleDeclaration*.
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++]
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #631288 -
Flags: feedback?(Ms2ger)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 631288 [details] [diff] [review] Patch(v1) Review of attachment 631288 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks!
Attachment #631288 -
Flags: review?(dholbert)
Attachment #631288 -
Flags: feedback?(Ms2ger)
Attachment #631288 -
Flags: feedback+
Comment 4•8 years ago
|
||
Comment on attachment 631288 [details] [diff] [review] Patch(v1) Looks good to me, too. Thanks!
Attachment #631288 -
Flags: review?(dholbert) → review+
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → jigneshhk1992
Keywords: checkin-needed
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1dc33884d5
Updated•8 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla16
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/85613734e341 https://hg.mozilla.org/mozilla-central/rev/6b1dc33884d5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•9 months ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•