As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 744157 - Return nsICSSDeclaration from Element::GetSMILOverrideStyle
: Return nsICSSDeclaration from Element::GetSMILOverrideStyle
[good first bug][mentor=Ms2ger][lang=...
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jignesh Kakadiya [:jhk]
: Andrew Overholt [:overholt]
Depends on:
Blocks: 743438
  Show dependency treegraph
Reported: 2012-04-10 13:36 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-09 19:50 PDT (History)
4 users (show)
dzbarsky: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch(v1) (5.28 KB, patch)
2012-06-07 23:55 PDT, Jignesh Kakadiya [:jhk]
dholbert: review+
Ms2ger: feedback+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2012-04-10 13:36:56 PDT

Comment 1 User image :Ms2ger (⌚ UTC+1/+2) 2012-06-07 04:46:27 PDT
See <>. The GetSMILOverrideStyle() function should return nsICSSDeclaration* instead of nsIDOMCSSStyleDeclaration*.
Comment 2 User image Jignesh Kakadiya [:jhk] 2012-06-07 23:55:29 PDT
Created attachment 631288 [details] [diff] [review]
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2012-06-08 00:05:48 PDT
Comment on attachment 631288 [details] [diff] [review]

Review of attachment 631288 [details] [diff] [review]:

Looks good to me. Thanks!
Comment 4 User image Daniel Holbert [:dholbert] 2012-06-08 00:11:14 PDT
Comment on attachment 631288 [details] [diff] [review]

Looks good to me, too. Thanks!
Comment 5 User image David Zbarsky (:dzbarsky) 2012-06-09 15:24:32 PDT
Comment 6 User image David Zbarsky (:dzbarsky) 2012-06-09 15:50:43 PDT
bustage fix:

Note You need to log in before you can comment on or make changes to this bug.