Last Comment Bug 744157 - Return nsICSSDeclaration from Element::GetSMILOverrideStyle
: Return nsICSSDeclaration from Element::GetSMILOverrideStyle
Status: RESOLVED FIXED
[good first bug][mentor=Ms2ger][lang=...
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jignesh Kakadiya [:jhk]
:
:
Mentors:
Depends on:
Blocks: 743438
  Show dependency tree / graph
 
Reported: 2012-04-10 13:36 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-09 19:50 PDT (History)
4 users (show)
dzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Patch(v1) (5.28 KB, patch)
2012-06-07 23:55 PDT, Jignesh Kakadiya [:jhk] 		dholbert: review+
Ms2ger: feedback+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-10 13:36:56 PDT 

    

  


      




        
          Comment 1
        

        
  
          :Ms2ger (⌚ UTC+1/+2)

       

        
        

        
          2012-06-07 04:46:27 PDT
        

      






See <http://mxr.mozilla.org/mozilla-central/ident?i=GetSMILOverrideStyle&filter=>. The GetSMILOverrideStyle() function should return nsICSSDeclaration* instead of nsIDOMCSSStyleDeclaration*.

    

  


      




        
          Comment 2
        

        
  
          Jignesh Kakadiya [:jhk]

       

        
        

        
          2012-06-07 23:55:29 PDT
        

      






Created attachment 631288 [details] [diff] [review]
Patch(v1)

    

  


      




        
          Comment 3
        

        
  
          :Ms2ger (⌚ UTC+1/+2)

       

        
        

        
          2012-06-08 00:05:48 PDT
        

      






Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Review of attachment 631288 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!

    

  


      




        
          Comment 4
        

        
  
          Daniel Holbert [:dholbert]

       

        
        

        
          2012-06-08 00:11:14 PDT
        

      






Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Looks good to me, too. Thanks!

    

  


      




        
          Comment 5
        

        
  
          David Zbarsky (:dzbarsky)

       

        
        

        
          2012-06-09 15:24:32 PDT
        

      






https://hg.mozilla.org/integration/mozilla-inbound/rev/85613734e341

    

  


      




        
          Comment 6
        

        
  
          David Zbarsky (:dzbarsky)

       

        
        

        
          2012-06-09 15:50:43 PDT
        

      






bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1dc33884d5

    

  
  

  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.