Closed Bug 744157 Opened 8 years ago Closed 8 years ago

Return nsICSSDeclaration from Element::GetSMILOverrideStyle

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: Ms2ger, Assigned: jhk)

References

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])

Attachments

(1 file)

Patch(v1)
5.28 KB, patch
dholbert
: review+
Ms2ger
: feedback+
Details | Diff | Splinter Review 
No description provided.
See <http://mxr.mozilla.org/mozilla-central/ident?i=GetSMILOverrideStyle&filter=>. The GetSMILOverrideStyle() function should return nsICSSDeclaration* instead of nsIDOMCSSStyleDeclaration*.
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++]
Attached patch Patch(v1) — — Splinter Review
Attachment #631288 - Flags: feedback?(Ms2ger)
Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Review of attachment 631288 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!
Attachment #631288 - Flags: review?(dholbert)
Attachment #631288 - Flags: feedback?(Ms2ger)
Attachment #631288 - Flags: feedback+
Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Looks good to me, too. Thanks!
Attachment #631288 - Flags: review?(dholbert) → review+
Assignee: nobody → jigneshhk1992
Keywords: checkin-needed
Flags: in-testsuite-
Target Milestone: --- → mozilla16
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.