The default bug view has changed. See this FAQ.

Return nsICSSDeclaration from Element::GetSMILOverrideStyle

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: jhk)

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
See <http://mxr.mozilla.org/mozilla-central/ident?i=GetSMILOverrideStyle&filter=>. The GetSMILOverrideStyle() function should return nsICSSDeclaration* instead of nsIDOMCSSStyleDeclaration*.
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++]
(Assignee)

Comment 2

5 years ago
Created attachment 631288 [details] [diff] [review]
Patch(v1)
Attachment #631288 - Flags: feedback?(Ms2ger)
(Reporter)

Comment 3

5 years ago
Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Review of attachment 631288 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!
Attachment #631288 - Flags: review?(dholbert)
Attachment #631288 - Flags: feedback?(Ms2ger)
Attachment #631288 - Flags: feedback+
Comment on attachment 631288 [details] [diff] [review]
Patch(v1)

Looks good to me, too. Thanks!
Attachment #631288 - Flags: review?(dholbert) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → jigneshhk1992
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/85613734e341
bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1dc33884d5
Flags: in-testsuite-
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/85613734e341
https://hg.mozilla.org/mozilla-central/rev/6b1dc33884d5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.