Closed Bug 744297 Opened 8 years ago Closed 8 years ago
uninitialized result in ns
This even causes a compiler warning, but I guess nobody noticed. Just an error code for a deserializer, so I think it shouldn't cause anything too bad, just random failures. nsresult rv; // Read Node Info PRUint32 number; rv |= aStream->Read32(&number);
Oh, this is bad. What this will do is cause random fastload failures! Want to patch? I'll review!
A freely offered bz review? I can't turn that down. I haven't compiled this yet, but it should do the trick. I should check this directory for other scary warnings.
Assignee: nobody → continuation
Attachment #613850 - Flags: review?(bzbarsky)
Comment on attachment 613850 [details] [diff] [review] initialize it r=me
Attachment #613850 - Flags: review?(bzbarsky) → review+
Try run looked good. I didn't see any other warnings in the directory aside from IDL things shadowing each other, and I looked over the patch from bug 741580 and didn't see any other problems. https://hg.mozilla.org/integration/mozilla-inbound/rev/c124fc77aab2
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.