744427 - revise blacklist in tamarin hook script to remove de-securitized bugs

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

Spawned off from Bug 744378.

Our security blacklist needs revision; in the short-term, we need to remove Bug 618215 from the list, because it has been de-securitized.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A: remove desecuritized bugs and reclassify others

removed desecuritized bugs: Bug 563795, Bug 567107, Bug 618215

reclassify others (w.r.t. version in comment): Bug 570049, Bug 628834

I considered trying to update the list more completely, but that is a more difficult task and is probably one we should be handling earlier in our new pipeline, if possible.

Comment 2

[Brent Baker]

Comment on attachment 614029 [details] [diff] [review]
patch A: remove desecuritized bugs and reclassify others

R+ with reservations, do we really want to support this? I mean, I think we need to back away from this methodology and NOT have blacklisted bugs here. This is probably something that is not maintainable since it will require a change to the hook and assistance from mozilla for deployment each time we wish to update.

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to Brent Baker from comment #2)
> R+ with reservations, do we really want to support this? I mean, I think we
> need to back away from this methodology and NOT have blacklisted bugs here.

true, I might rip it out entirely.  I'll sleep on it.

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

Ripping out the code entirely is attractive, but this patch is simple and ready to land now.

I'm going to land this, and open up a fresh ticket for investigating removal of the security checks from the hg.mozilla.org/tamarin-redux repo.

Comment 5

[Felix S. Klock II [:pnkfelix, :fklock]]

(In reply to Felix S Klock II from comment #4)
> I'm going to land this, and open up a fresh ticket for investigating removal
> of the security checks from the hg.mozilla.org/tamarin-redux repo.

Spawned off in Bug 752582