744441 - crash in java.lang.IllegalArgumentException: account is null at android.accounts.AccountManager.getUserData(AccountManager.java:322)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug was filed from the Socorro interface and is 
report bp-10607757-e464-40ac-a5a6-e1a122120409 .
============================================================= 
java.lang.IllegalArgumentException: account is null
	at android.accounts.AccountManager.getUserData(AccountManager.java:322)
	at org.mozilla.gecko.sync.syncadapter.SyncAdapter.getClientsCount(SyncAdapter.java:452)
	at org.mozilla.gecko.sync.syncadapter.SyncAdapter.getSyncInterval(SyncAdapter.java:315)
	at org.mozilla.gecko.sync.syncadapter.SyncAdapter.onPerformSync(SyncAdapter.java:302)
	at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:167)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

I've seen this 5 times today

Comment 2

[Scoobidiver (away)]

In fact, it was hit by only two users (two different OSes) from 14.0a1/20120408.

Comment 3

[Richard Newman [:rnewman]]

Stealing this. This isn't supposed to be possible.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: log

Comment 5

[Richard Newman [:rnewman]]

The short-term issue here is that we're being handed a 'null' account (one that includes no fields, so we can't sync with it), but our backoff code isn't aware of this error case.

Should be a trivial fix.

The root cause is having more than one Fennec installed; I don't think Android deals well with authenticators that attach metadata to the account (in that I think it stores metadata per-authenticator, and we have multiple authenticators), and so we end up with a blank account object when we're asked to sync.

Suggesting softblocker to avoid crash reports.

Comment 6

[Richard Newman [:rnewman]]

Not critical; not a common (or actually supported) scenario.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca8d60bd5994

Thanks for testing, Chenxia.

This fix will correctly and quietly skip the sync if we get a blank Account object. It also disables syncing this product.

QA: to repro, you need two versions of Fennec installed. Verify that when the second syncs, it produces log output "No credentials attached to account. Aborting sync.", and that afterwards only one box is checked in the account settings app. The other version of Fennec should sync correctly.

Behavior with only one Fennec installed should be unchanged.

Comment 8

[Richard Newman [:rnewman]]

Attachment: Patch.

Low-risk fix for an edge case, avoids crash submissions.

Happy to let this bake on m-c for a couple days; just flagging so I don't forget about it!

Comment 9

[Chenxia Liu [:liuche]]

Tested and works as expected.

STR

- Install two versions of Android Firefox (e.g., Fennec-debug and Nightly)
- Set up sync through the Firefox version that is *not* being tested for the fix (if both versions have the fix, it doesn't matter)
- Go to Settings > Accounts > (Firefox Sync account)
- Under "Data & Synchronization," only the Firefox version that Sync was set up through will be checked.
- Check the box for the Firefox version that is being tested. Sync should be kicked off automatically; if not, force a sync.

Expected:
No errors in the logs. In "Data & Synchronization" the newly checked Firefox version should be unchecked again.

Previous errors:
Fennec would "stop unexpectedly." Errors show up in the logs for "account is null".

Comment 10

[Richard Newman [:rnewman]]

Removing GitHub annotation: this is in mozilla-inbound, which is why there's a target milestone set.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ca8d60bd5994

Comment 12

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/14173aceb23e

Comment 13

[Cristian Nicolae (:xti)]

This crash doesn't occur anymore on the latest Aurora and Nightly builds. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-29)
Firefox 14.0a2 (2012-05-29)

Device: Galaxy Nexus
OS: Android 4.0.2