744446 - consistency in Socorro unit tests

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[K Lars Lohn [:lars] [:klohn]]

many of the Socorro unit tests announce themselves in the nosetests output like this:

    ==== socorro.unittest.cron.testBugzilla ====
    ============================================

many do not do this.

Either all of them should do it, or none of them should do it.  I suggest that none should.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

(In reply to K Lars Lohn [:lars] [:klohn] from comment #0)

> Either all of them should do it, or none of them should do it.  I suggest
> that none should.

Really? I found it pretty useful that we see all tests executing, especially in jenkins logs. I always like to see that things were done, when nothing is displayed how can you be sure that your test was run?

Comment 2

[K Lars Lohn [:lars] [:klohn]]

My opinion is malleable and not strongly held.  I'd rather have consistency than either particular option: one or the other, not the mishmash of both.

I like the cleanliness of just the row of dots.  If I want to be assured that a specific test ran, then:

   export NOSE_VERBOSE=2

that gives me lots more information.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Adrian Gaudebert [:adrian] from comment #1)
> (In reply to K Lars Lohn [:lars] [:klohn] from comment #0)
> 
> > Either all of them should do it, or none of them should do it.  I suggest
> > that none should.
> 
> Really? I found it pretty useful that we see all tests executing, especially
> in jenkins logs. I always like to see that things were done, when nothing is
> displayed how can you be sure that your test was run?

The problem is that not all tests do this, they have to use the Socorro-specific unittest util (most of the newer ones do not), so you're not actually seeing all the tests printed.

I agree with lars, nose can be configured to show this if we want to see it in the jenkins output - there's no reason to have custom code for it.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

If we can configure jenkins to show more details, then removing all output works for me. It's actually going to make the code a little bit cleaner too... :)

Comment 5

[Gabriela Thumé]

I think this bug was already solved because I didn't find any tests with output like:
 
==== socorro.unittest.cron.testBugzilla ====
============================================

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Oh, yes, here is the commit: https://github.com/mozilla/socorro/commit/88ab1ae1c030df7ccdfb8fd9a01173ec47373c97

I did not remember there was a bug for it. :)