Closed Bug 744644 Opened 8 years ago Closed 8 years ago

ProfileMigrator never sets PREFS_MIGRATE_BOOKMARKS_DONE pref if places.sqlite doesn't exist

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: nalexander, Assigned: gcp)

References

Details

(Whiteboard: [sync])

Attachments

(1 file)

I hit this because the "control" ContentProvider always fails if we never need to migrate.

A little digging reveals that ProfileMigrator.migratePlaces early aborts if places.sqlite doesn't exist (which it won't if you never run XUL Fennec), and the flag that the CP is checking ( PREFS_MIGRATE_BOOKMARKS_DONE) is only ever set after the early abort.
Assignee: nobody → gpascutto
Attachment #614353 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 614353 [details] [diff] [review]
Patch 1. Mark as finished when nothing to do

Review of attachment 614353 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. Nom this bug.
Attachment #614353 - Flags: review?(lucasr.at.mozilla) → review+
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → beta+
Whiteboard: [sync]
https://hg.mozilla.org/mozilla-central/rev/4aa05c31b01a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.