Closed
Bug 744644
Opened 12 years ago
Closed 12 years ago
ProfileMigrator never sets PREFS_MIGRATE_BOOKMARKS_DONE pref if places.sqlite doesn't exist
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-fennec1.0 beta+)
RESOLVED
FIXED
Firefox 14
| Tracking | Status | |
|---|---|---|
| blocking-fennec1.0 | --- | beta+ |
People
(Reporter: nalexander, Assigned: gcp)
References
Details
(Whiteboard: [sync])
Attachments
(1 file)
|
1.26 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
I hit this because the "control" ContentProvider always fails if we never need to migrate. A little digging reveals that ProfileMigrator.migratePlaces early aborts if places.sqlite doesn't exist (which it won't if you never run XUL Fennec), and the flag that the CP is checking ( PREFS_MIGRATE_BOOKMARKS_DONE) is only ever set after the early abort.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → gpascutto
Attachment #614353 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 614353 [details] [diff] [review] Patch 1. Mark as finished when nothing to do Review of attachment 614353 [details] [diff] [review]: ----------------------------------------------------------------- Yep. Nom this bug.
Attachment #614353 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Updated•12 years ago
|
blocking-fennec1.0: --- → ?
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4aa05c31b01a
|
||
Updated•12 years ago
|
blocking-fennec1.0: ? → beta+
Whiteboard: [sync]
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4aa05c31b01a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•