744675 - Autodetect a sane -j# for jsreftest runner

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

This would be a nice feature to have.

Comment 1

[Josh Matthews [:jdm]]

Terrence, could you drop some links to the relevant source files and comment on a suggested method of autodetection?

Comment 2

[Terrence Cole [:terrence]]

(In reply to Josh Matthews [:jdm] from comment #1)
> Terrence, could you drop some links to the relevant source files and comment
> on a suggested method of autodetection?

The jsreftest testsuite code is in js/src/tests/.  The main file that will need modification is jstests.py.

I had couple of specific API's in mind, but it turns out someone has already made a comprehensive list; we should be able to get away with just cribbing from stackoverflow:

http://stackoverflow.com/questions/1006289/how-to-find-out-the-number-of-cpus-in-python

Comment 3

[Terrence Cole [:terrence]]

MXR link for where we add the -j arg:
http://mxr.mozilla.org/mozilla-central/source/js/src/tests/jstests.py#68

It would be easiest to set the default= parameter here to the output of the function in the stack-overflow article.

Comment 4

[Terrence Cole [:terrence]]

Attachment: v0

And updates the core help with output format notes, since I was in the area.

Comment 5

[Steve Fink [:sfink] [:s:]]

Comment on attachment 646767 [details] [diff] [review]
v0

Review of attachment 646767 [details] [diff] [review]:
-----------------------------------------------------------------

I think I'll just take your word for this one. For the default, why go down to 1, though? It seems like if somebody bothers to specify -j, then they'd expect at least 2.

Comment 6

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/088951918af8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/088951918af8