Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Autodetect a sane -j# for jsreftest runner

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

16 Branch
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This would be a nice feature to have.
(Assignee)

Updated

5 years ago
Assignee: terrence → nobody
Blocks: 745230
Component: JavaScript Engine → IPC
Keywords: helpwanted
QA Contact: general → ipc
Whiteboard: [good first bug][easy][mentor=terrence][lang=python]

Updated

5 years ago
Assignee: nobody → general
Component: IPC → JavaScript Engine
QA Contact: ipc → general

Comment 1

5 years ago
Terrence, could you drop some links to the relevant source files and comment on a suggested method of autodetection?
(Assignee)

Comment 2

5 years ago
(In reply to Josh Matthews [:jdm] from comment #1)
> Terrence, could you drop some links to the relevant source files and comment
> on a suggested method of autodetection?

The jsreftest testsuite code is in js/src/tests/.  The main file that will need modification is jstests.py.

I had couple of specific API's in mind, but it turns out someone has already made a comprehensive list; we should be able to get away with just cribbing from stackoverflow:

http://stackoverflow.com/questions/1006289/how-to-find-out-the-number-of-cpus-in-python
(Assignee)

Comment 3

5 years ago
MXR link for where we add the -j arg:
http://mxr.mozilla.org/mozilla-central/source/js/src/tests/jstests.py#68

It would be easiest to set the default= parameter here to the output of the function in the stack-overflow article.
(Assignee)

Updated

5 years ago
Keywords: helpwanted
Whiteboard: [good first bug][easy][mentor=terrence][lang=python]
Version: Trunk → 16 Branch
(Assignee)

Comment 4

5 years ago
Created attachment 646767 [details] [diff] [review]
v0

And updates the core help with output format notes, since I was in the area.
Assignee: general → terrence
Attachment #646767 - Flags: review?(sphink)
Comment on attachment 646767 [details] [diff] [review]
v0

Review of attachment 646767 [details] [diff] [review]:
-----------------------------------------------------------------

I think I'll just take your word for this one. For the default, why go down to 1, though? It seems like if somebody bothers to specify -j, then they'd expect at least 2.
Attachment #646767 - Flags: review?(sphink) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/088951918af8
https://hg.mozilla.org/mozilla-central/rev/088951918af8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.