Closed
Bug 744770
Opened 12 years ago
Closed 12 years ago
Master Password dummy pref should not be saved
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-fennec1.0 beta+)
RESOLVED
FIXED
Firefox 14
Tracking | Status | |
---|---|---|
blocking-fennec1.0 | --- | beta+ |
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
1.38 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
We use a dummy pref to make the MasterPassword code fit into the current Preference Model, but it's not a real pref and we should not allow it to be saved as a pref.
Attachment #614356 -
Flags: review?(wjohnston)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mark.finkle
Assignee | ||
Comment 1•12 years ago
|
||
The key change is adding the | return; | to leave the function early and not save the data.
Updated•12 years ago
|
Attachment #614356 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2d751d71d64
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a2d751d71d64
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•