744838 - crash in java.lang.NullPointerException at java.util.concurrent.SynchronousQueue.put(SynchronousQueue.java:814)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug was filed from the Socorro interface and is 
report bp-ab9b0cac-1ca0-4d06-82dc-662be2120411 .
============================================================= 
java.lang.NullPointerException
	at java.util.concurrent.SynchronousQueue.put(SynchronousQueue.java:814)
	at org.mozilla.gecko.GeckoApp$FilePickerResultHandlerSync.onActivityResult(GeckoApp.java:2657)
	at org.mozilla.gecko.GeckoApp.onActivityResult(GeckoApp.java:2600)
	at android.app.Activity.dispatchActivityResult(Activity.java:3944)
	at android.app.ActivityThread.deliverResults(ActivityThread.java:2528)
	at android.app.ActivityThread.handleSendResult(ActivityThread.java:2574)
	at android.app.ActivityThread.access$2000(ActivityThread.java:117)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:961)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3683)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:850)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:608)
	at dalvik.system.NativeStart.main(Native Method)

STR: 
1. go to http://people.mozilla.com/~nhirata/html_tp/bug725953.html
2. click inside the text field
3. choose a file picker like ASTRO if it's installed
4. hit back button twice

Expected: no crash
Actual: crash

Note: I don't think we should crash if we get a NULL returned from a third party app...

Comment 1

[Chris Peterson [:cpeterson]]

blassey, GeckoApp.FilePickerResultHandlerSync looks like code you last touched. The fix looks straightforward.

Comment 2

[Chris Peterson [:cpeterson]]

This was our #1 crash yesterday and #3 for the last few days.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 615533 [details] [diff] [review]
patch

Review of attachment 615533 [details] [diff] [review]:
-----------------------------------------------------------------

Could you just check for FilePickerResultHandler.handleActivityResult()'s null return value (and convert it to an empty string) in FilePickerResultHandlerSync.onActivityResult()? That seems like a simpler and more robust solution.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Chris Peterson (:cpeterson) from comment #4)
> Comment on attachment 615533 [details] [diff] [review]
> patch
> 
> Review of attachment 615533 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Could you just check for FilePickerResultHandler.handleActivityResult()'s
> null return value (and convert it to an empty string) in
> FilePickerResultHandlerSync.onActivityResult()? That seems like a simpler
> and more robust solution.

could, but I actually don't want FilePickerResultHandlerASync returning null either, so I like this solution better.

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 615533 [details] [diff] [review]
patch

Review of attachment 615533 [details] [diff] [review]:
-----------------------------------------------------------------

OK

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 615533 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/24d7f09f3891

Comment 9

[JP Rosevear [:jpr]]

Comment on attachment 615533 [details] [diff] [review]
patch

Returning empty string instead of null.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a68244c078b

Comment 11

[Cristian Nicolae (:xti)]

This crash cannot be reproducible anymore on the latest Nightly and Aurora builds if STR from comment #0 are performed. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-30)
Firefox 14.0a2 (2012-05-30)

Device: Galaxy Nexus
OS: Android 4.0.2