Last Comment Bug 744865 - Build fails with: Undefined symbols: nsEudoraHTMLImageElement::MozRequestPointerLock() and nsOutlookHTMLImageElement::MozRequestPointerLock
: Build fails with: Undefined symbols: nsEudoraHTMLImageElement::MozRequestPoin...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: x86 All
: -- critical (vote)
: Thunderbird 14.0
Assigned To: Mike Conley (:mconley) - (Needinfo me!)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-12 11:30 PDT by Mike Conley (:mconley) - (Needinfo me!)
Modified: 2012-04-12 16:36 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Stubs (1.13 KB, patch)
2012-04-12 12:12 PDT, Mike Conley (:mconley) - (Needinfo me!)
no flags Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (Needinfo me!) 2012-04-12 11:30:19 PDT

    
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-04-12 11:31:44 PDT
This seems to be affecting at least our OSX and Windows builders:

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTrunk&rev=c79faac0f542
Comment 2 Mike Conley (:mconley) - (Needinfo me!) 2012-04-12 12:12:35 PDT
Created attachment 614485 [details] [diff] [review]
Stubs

Here are some stubs for MozRequestPointerLock.

Assuming this builds locally (currently underway), I'll push it up.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2012-04-12 12:46:52 PDT
Fix pushed to comm-central as http://hg.mozilla.org/comm-central/rev/ab32d49d5df6

David (Humphrey): Looking at both nsEudoraEditor and nsOutlookEditor, it looks like we stub out a *lot* of stuff that you'd think we normally get from GenericElement.

So I don't think MozRequestPointerLock is much of an exception, and probably not worth your time to investigate, unless you're really eager to dig into it.
Comment 4 David :Bienvenu 2012-04-12 12:54:22 PDT
we probably can't inherit from GenericElement since we don't link directly against things in gecko.
Comment 5 David Humphrey (:humph) 2012-04-12 16:20:50 PDT
Sorry for the bustage.  Am I to understand, based on your findings above, that simply stubbing out as you've done here is enough, and we don't need to do further surgery?
Comment 6 Mike Conley (:mconley) - (Needinfo me!) 2012-04-12 16:36:33 PDT
humph:

No worries - we're all good now.  Thanks for following up!

-Mike

Note You need to log in before you can comment on or make changes to this bug.