74491 - Uninitialized member in nsDBFolderInfo

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[John G. Myers]

It looks like nsDBFolderInfo::nsDBFolderInfo(nsMsgDatabase *) doesn't initialize 
m_mdb if its argument is a null pointer.


[W] UMR: Uninitialized memory read in nsDBFolderInfo::~nsDBFolderInfo(void) {1 
occurrence}
    Reading 4 bytes from 0x16bcc2f0 (4 bytes at 0x16bcc2f0 uninitialized)
    Address 0x16bcc2f0 is 104 bytes into a 212 byte block at 0x16bcc288
    Address 0x16bcc2f0 points to a C++ new block in heap 0x03310000
    Thread ID: 0x135
    Error location
        nsDBFolderInfo::~nsDBFolderInfo(void) [nsDBFolderInfo.cpp:172]
        nsTransferDBFolderInfo::~nsTransferDBFolderInfo(void) 
[nsDBFolderInfo.cpp:821]
        nsTransferDBFolderInfo::`scalar deleting destructor'(UINT) [msgdb.dll]
        nsDBFolderInfo::Release(void) [nsDBFolderInfo.cpp:76]
        nsCOMPtr<nsIDBFolderInfo>::~nsCOMPtr<nsIDBFolderInfo>(void) 
[nsCOMPtr.h:488]
        nsMsgLocalMailFolder::GetDatabase(nsIMsgWindow *) 
[nsLocalMailFolder.cpp:545]
        nsMsgLocalMailFolder::UpdateFolder(nsIMsgWindow *) 
[nsLocalMailFolder.cpp:583]
        XPTC_InvokeByIndex [xptcinvoke.cpp:137]
        nsXPCWrappedNativeClass::CallWrappedMethod(JSContext 
*,nsXPCWrappedNative *,XPCNativeMemberDescriptor 
const*,CallMode::nsXPCWrappedNativeClass,UINT,long *,long *) 
[xpcwrappednativeclass.cpp:934]
        WrappedNative_CallMethod(JSContext *,JSObject *,UINT,long *,long *) 
[xpcwrappednativejsops.cpp:250]
    Allocation location
        new(UINT)      [new.cpp:23]
        nsDBFolderInfo::GetTransferInfo(nsIDBFolderInfo * *) 
[nsDBFolderInfo.cpp:829]
        nsMsgLocalMailFolder::GetDatabase(nsIMsgWindow *) 
[nsLocalMailFolder.cpp:530]
        nsMsgLocalMailFolder::UpdateFolder(nsIMsgWindow *) 
[nsLocalMailFolder.cpp:583]
        XPTC_InvokeByIndex [xptcinvoke.cpp:137]
        nsXPCWrappedNativeClass::CallWrappedMethod(JSContext 
*,nsXPCWrappedNative *,XPCNativeMemberDescriptor 
const*,CallMode::nsXPCWrappedNativeClass,UINT,long *,long *) 
[xpcwrappednativeclass.cpp:934]
        WrappedNative_CallMethod(JSContext *,JSObject *,UINT,long *,long *) 
[xpcwrappednativejsops.cpp:250]

Comment 1

[David :Bienvenu]

trivial fix checked in.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

1.64 bienvenu%netscape.com Apr 11 21:47 make sure m_mdb gets assigned so we
don't have UMR read sr=sspitzer, no bug

the change was to initialize early.