745021 - mozharness.mozilla.testing.talos should make use of basetest for binary installation/finding

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/mozharness/file/b8941a8b52e5/mozharness/mozilla/testing/talos.py
currently has its own ad hoc method of dealing with the Firefox
binary.  Instead, it should use the mixin class from http://hg.mozilla.org/build/mozharness/file/b8941a8b52e5/mozharness/mozilla/testing/testbase.py#l45

Comment 1

[Aki Sasaki (not active)]

Attachment: wip (untested)

Need to test.

A few things:
* I renamed check() to _pre_config_lock(), which is called automatically from BaseScript.__init__().  I definitely don't want us mucking too much in the config here, but we're able to do all those checks, at least.
* talos_options and config_options seem to not really be that separate in purpose anymore; I'm inclined to combine the two into a single list.
* I need to set c['require_test_zip'] to True for peptest.
* TestingMixin.postflight_read_buildbot_config() is ugly, but I'm not sure what to do about it.
* Putting download and extract together makes sense for peptest, but isn't particularly necessary for talos.  Maybe I should make smaller functions in TestingMixin, and I can create a Peptest.download_and_extract() that calls TestingMixin.download() and TestingMixin.extract().

Comment 2

[Aki Sasaki (not active)]

Attachment: this doesn't break peptest

I didn't know that package_name.lower would pass syntax checks without the () =\

This fixes that and adds the 'require_test_zip' config to peptest.
Ran on winxp; works.

Comment 3

[Jeff Hammel]

Comment on attachment 614652 [details] [diff] [review]
this doesn't break peptest

Thanks.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 614652 [details] [diff] [review]
this doesn't break peptest

http://hg.mozilla.org/build/mozharness/rev/dd81d754a7fd