Crash in ImageCache.cpp when cache disabled

VERIFIED FIXED in mozilla0.9

Status

()

Core
ImageLib
P4
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Peter ``jag'' Annema, Assigned: Stuart Parmenter)

Tracking

({crash})

Trunk
mozilla0.9
x86
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
To prefs.js add:

user_pref("browser.cache.enable", false);

(Additionally, have:
user_pref("browser.enable.cache", false);
user_pref("browser.cache.disk.enable", false);
not sure if it's needed but I'm too tired/lazy to figure out right now)

start mozilla. See it crash.

The problem is that an assumption is made about the cache always being
available, which is wrong (GetCacheSession(...)).

I'll attach my quick hack which "fixed" this for me.
(Reporter)

Comment 1

17 years ago
Created attachment 29570 [details] [diff] [review]
[patch] hacky fix

Comment 2

17 years ago
+    //NS_ASSERTION(gSession, "Unable to create a cache session");
doesn't make much sense, either add a line that outputs a warning or don't put 
anything back.
(Reporter)

Comment 3

17 years ago
Sorry timeless, next time I'll more explicitely say "this is _not_ supposed to
be checked in as is, it is merely an indication of what I did to work around /
fix this bug" to save you the trouble of reviewing the code :-)
(Assignee)

Comment 4

17 years ago
Created attachment 30108 [details] [diff] [review]
patch
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: crash, patch
Priority: -- → P4
Target Milestone: --- → mozilla0.9
(Reporter)

Comment 5

17 years ago
r=jag
(Assignee)

Comment 6

17 years ago
Created attachment 30171 [details] [diff] [review]
patch that works
(Assignee)

Comment 7

17 years ago
this patch actually compiles and doesn't crash :-)
(Reporter)

Comment 8

17 years ago
Erh, duh. r=jag
sr=blizzard
(Assignee)

Comment 10

17 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.