Last Comment Bug 745054 - [Azure] Make skia usable on windows by pref and build options
: [Azure] Make skia usable on windows by pref and build options
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla14
Assigned To: Bas Schouten (:bas.schouten)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-12 18:27 PDT by Bas Schouten (:bas.schouten)
Modified: 2012-04-13 04:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Fix skia compilation on windows (1.12 KB, patch)
2012-04-12 18:33 PDT, Bas Schouten (:bas.schouten)
matt.woodrow: review+
Details | Diff | Splinter Review
Part 2: Allow factory construction of skia drawtargets (1.51 KB, patch)
2012-04-12 18:34 PDT, Bas Schouten (:bas.schouten)
matt.woodrow: review+
Details | Diff | Splinter Review

Description Bas Schouten (:bas.schouten) 2012-04-12 18:27:25 PDT
Right now --enable-skia doesn't compile on windows. In addition to that switching off Direct2D and using prefer-skia does -not- make you use Skia. A couple of tiny patches remidy this. Coming up.
Comment 1 Bas Schouten (:bas.schouten) 2012-04-12 18:33:31 PDT
Created attachment 614646 [details] [diff] [review]
Part 1: Fix skia compilation on windows
Comment 2 Bas Schouten (:bas.schouten) 2012-04-12 18:34:03 PDT
Created attachment 614647 [details] [diff] [review]
Part 2: Allow factory construction of skia drawtargets

Note You need to log in before you can comment on or make changes to this bug.