memcached backend doesn't filter tabs correctly

VERIFIED FIXED

Status

Cloud Services
Server: Sync
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: rfkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 614660 [details] [diff] [review]
patch to fix tab filtering in memcached backend

A simple typo/oversight in the memcached backend causes it not to apply query parameter filters like "newer" to the tabs collection.  Attached patch should be self-explanatory.

There's actually already a test for this as part of the functional suite, but `make test` doesn't run it against the memcached backend by default.  We should fix the test suite to enable this, but that's a separate bug.
Attachment #614660 - Flags: review?(telliott)
Attachment #614660 - Flags: review?(telliott) → review+
(Reporter)

Comment 1

6 years ago
https://github.com/mozilla-services/server-syncstorage/commit/36c2dc8d77699c514fe6a44384a0feb9424a9a5d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Code verified and passed functional tests of Sync 2.0 and AITC 1.0 for a current deploy to qa1.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 3

5 years ago
Backported to sync1.1: http://hg.mozilla.org/services/server-storage/rev/ec7f28650fa8
OK. Will re-verify against sync 1.1.
You need to log in before you can comment on or make changes to this bug.