745114 - B2G Wifi: trigger `onstatuschange' callbacks when the wifi status changes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fabien Cazenave [:kaze]]

following bug 740079

To get along with the synchronous `status' property, it would be nice to support `onstatuschange' callbacks. There are a few use cases where this would be easier than a set of onconnect / onconnecting / ondisconnect / etc. event listeners and it would be more XHR-like.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v1

This should be pretty straightforward. The one thing I wondered about was whether it was worth it to change the internal (IPC) notifications to follow the DOM API. I decided against it since not all of the notifications did exactly the same thing (in particular, disconnect is handled a little differently). Any opinions on that would be welcome.

Comment 2

[Fabien Cazenave [:kaze]]

>+     *   - disconnected: Fires when we either fail to connect to an access
>+     *                   point (transition: onassociate -> ondisconnect) or
>+     *                   when we were connected to a network but have
>+     *                   disconnected for any reason (transition: onconnect ->
>+     *                   ondisconnect).

nit:
  transition: associated -> disconnected
  transition: connected -> disconnected

Comment 3

[Fabien Cazenave [:kaze]]

Here’s a preliminary front-end:
https://github.com/andreasgal/gaia/pull/1226

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3aea7115d3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1d3aea7115d3