745173 - balrog's requirepermission decorator passes wrong thing to hasUrlPermission

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

hasUrlPermission matches against a permission name, which is a templatized version of a real URL. requirepermission currently passes a non-templatized, real URL to hasUrlPermission. Because of this, permission matching doesn't work at all, except for 'admin' users.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: fix granular permission checking

Alright, this is the simplest way to solve this: require each view to pass its granular permission to requirpermission, rather than using the real one out of the request. I also added a couple of tests.

Another way to do this would be pass the real URL to hasUrlPermission, and have it iterate over all possible permissions and match against them. This seemed pretty painful and more expensive, though.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 614763 [details] [diff] [review]
fix granular permission checking

jenkins run is here: https://jenkins.mozilla.org/job/Balrog/72/

Comment 3

[[e-mail] (:bhearsum)]

This worked.