Closed
Bug 745395
Opened 12 years ago
Closed 12 years ago
Replying to attached emails doesn't show the original message
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird12+ fixed, thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: squib, Assigned: mkmelin)
References
Details
(Keywords: regression)
Attachments
(2 files)
2.13 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
7.29 KB,
patch
|
Bienvenu
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Works: 12/30/2011, broken: 12/31/2011. If you open an attached message and try to reply to it, it shows the prelude "On x/y/z, Bob said", but doesn't actually quote the original message. Not sure what happened here...
Reporter | ||
Updated•12 years ago
|
tracking-thunderbird12:
--- → ?
Reporter | ||
Comment 1•12 years ago
|
||
Bug 389650 is probably related...
Assignee | ||
Updated•12 years ago
|
Keywords: regression
May be related to bug 743739 (for TB 11)? There are 2 issues there, but "no quoted text" seems to be one of them.
Assignee | ||
Comment 4•12 years ago
|
||
No this is from bug 389650... i misread one char there.
Assignee | ||
Comment 5•12 years ago
|
||
One if-clause was using &... and the other ?... This fixes it and makes it irrelevant where in the uri the param happens to be - still need to make a test for it.
Reporter | ||
Comment 6•12 years ago
|
||
I tested this out and it fixes the error for me.
Comment 7•12 years ago
|
||
Comment on attachment 615436 [details] [diff] [review] proposed fix David, can you take a look at this? If we want it for 12 (which is where bug 389650 landed), then we'll need to land it asap.
Attachment #615436 -
Flags: review?(dbienvenu)
Comment 8•12 years ago
|
||
Comment on attachment 615436 [details] [diff] [review] proposed fix would be good to have a mozmill test for this.
Attachment #615436 -
Flags: review?(dbienvenu) → review+
Assignee | ||
Comment 9•12 years ago
|
||
With test - i won't be able to check in until tomorrow at the earliest, so if someone wants to do that...
Attachment #615801 -
Flags: review?(dbienvenu)
Comment 10•12 years ago
|
||
Comment on attachment 615801 [details] [diff] [review] proposed fix with test thx so much, Magnus! I'll land this today, as soon as I verify that the test passes w/ the patch. I've verified that it fails w/o it.
Updated•12 years ago
|
Attachment #615801 -
Flags: review?(dbienvenu) → review+
Comment 11•12 years ago
|
||
fixed on trunk, thx, Magnus
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment 12•12 years ago
|
||
Comment on attachment 615801 [details] [diff] [review] proposed fix with test reply, forward inline of .eml attachments won't work w/o this patch.
Attachment #615801 -
Flags: approval-comm-beta?
Attachment #615801 -
Flags: approval-comm-aurora?
Comment 13•12 years ago
|
||
Comment on attachment 615801 [details] [diff] [review] proposed fix with test a=Standard8 to fix the regression.
Attachment #615801 -
Flags: approval-comm-beta?
Attachment #615801 -
Flags: approval-comm-beta+
Attachment #615801 -
Flags: approval-comm-aurora?
Attachment #615801 -
Flags: approval-comm-aurora+
Comment 14•12 years ago
|
||
(In reply to David :Bienvenu from comment #11) > fixed on trunk, thx, Magnus Trunk changeset: http://hg.mozilla.org/comm-central/rev/c89cbdbd4d64
Comment 15•12 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/545a5c12ef35 http://hg.mozilla.org/releases/comm-beta/rev/d464d18772e8
Assignee | ||
Updated•12 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•