Replying to attached emails doesn't show the original message

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: squib, Assigned: Magnus Melin)

Tracking

({regression})

12 Branch
Thunderbird 14.0
regression
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird12+ fixed, thunderbird13 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Works: 12/30/2011, broken: 12/31/2011.

If you open an attached message and try to reply to it, it shows the prelude "On x/y/z, Bob said", but doesn't actually quote the original message. Not sure what happened here...
(Reporter)

Updated

5 years ago
tracking-thunderbird12: --- → ?
(Reporter)

Comment 1

5 years ago
Bug 389650 is probably related...
(Assignee)

Updated

5 years ago
Keywords: regression
(Assignee)

Comment 2

5 years ago
Hm, i think i spot the error.
Assignee: nobody → mkmelin+mozilla
(Assignee)

Updated

5 years ago
Blocks: 389650

Comment 3

5 years ago
May be related to bug 743739 (for TB 11)? There are 2 issues there, but "no quoted text" seems to be one of them.
(Assignee)

Comment 4

5 years ago
No this is from bug 389650... i misread one char there.
(Assignee)

Comment 5

5 years ago
Created attachment 615436 [details] [diff] [review]
proposed fix

One if-clause was using &... and the other ?...

This fixes it and makes it irrelevant where in the uri the param happens to be - still need to make a test for it.
(Reporter)

Comment 6

5 years ago
I tested this out and it fixes the error for me.
Comment on attachment 615436 [details] [diff] [review]
proposed fix

David, can you take a look at this? If we want it for 12 (which is where bug 389650 landed), then we'll need to land it asap.
Attachment #615436 - Flags: review?(dbienvenu)

Comment 8

5 years ago
Comment on attachment 615436 [details] [diff] [review]
proposed fix

would be good to have a mozmill test for this.
Attachment #615436 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 615801 [details] [diff] [review]
proposed fix with test

With test - i won't be able to check in until tomorrow at the earliest, so if someone wants to do that...
Attachment #615801 - Flags: review?(dbienvenu)

Comment 10

5 years ago
Comment on attachment 615801 [details] [diff] [review]
proposed fix with test

thx so much, Magnus! I'll land this today, as soon as I verify that the test passes w/ the patch. I've verified that it fails w/o it.

Updated

5 years ago
Attachment #615801 - Flags: review?(dbienvenu) → review+

Comment 11

5 years ago
fixed on trunk, thx, Magnus
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Comment 12

5 years ago
Comment on attachment 615801 [details] [diff] [review]
proposed fix with test

reply, forward inline of .eml attachments won't work w/o this patch.
Attachment #615801 - Flags: approval-comm-beta?
Attachment #615801 - Flags: approval-comm-aurora?
Comment on attachment 615801 [details] [diff] [review]
proposed fix with test

a=Standard8 to fix the regression.
Attachment #615801 - Flags: approval-comm-beta?
Attachment #615801 - Flags: approval-comm-beta+
Attachment #615801 - Flags: approval-comm-aurora?
Attachment #615801 - Flags: approval-comm-aurora+
(In reply to David :Bienvenu from comment #11)
> fixed on trunk, thx, Magnus

Trunk changeset: http://hg.mozilla.org/comm-central/rev/c89cbdbd4d64
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/545a5c12ef35
http://hg.mozilla.org/releases/comm-beta/rev/d464d18772e8
status-thunderbird12: --- → fixed
status-thunderbird13: --- → fixed
tracking-thunderbird12: ? → +
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.