745454 - one-to-many mapping by text-transform:uppercase (e.g. ß) interferes with line-breaking

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase showing lack of line-breaking before uppercased ß

When a character is expanded by text-transform:uppercase (applies to ß, but will apply to more characters when bug 744357 is fixed), a preceding line-break opportunity is lost.

Comment 1

[Alice0775 White]

Regression window
Last good:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9b2pre) Gecko/2007110805 Firefox/3.0b2pre ID:2007110805
First bad:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9b2pre) Gecko/2007110905 Firefox/3.0b2pre ID:2007110905

Bonsai log:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-11-08+00%3A00%3A00&maxdate=2007-11-09+05%3A00%3A00&cvsroot=%2Fcvsroot

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch, preserve line-breaks when merging characters from transformed run

Looks like the problem is that MergeCharactersInTextRun fails to copy the right CanBreakBefore flag when it sets the merged glyph data in the destination, because by that time the "g" variable is starting out as a copy of the *last* source glyph record, not the first.

This patch resolves that problem, although in testing this I've noticed another line-breaking anomaly as well, which I'll file as a separate bug (it's not limited to the uppercase-ß situation).

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 615081 [details] [diff] [review]
patch, preserve line-breaks when merging characters from transformed run

Review of attachment 615081 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ac4bfd734aa

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5ac4bfd734aa