Move talosCmd into SUITES loop (generateTalosBranchObjects)

RESOLVED FIXED

Status

Release Engineering
Release Automation: Other
P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jhopkins, Assigned: jhopkins)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
talosCmd is defined outside the loop at:

 http://hg.mozilla.org/build/buildbotcustom/file/a26ac343141d/misc.py#l3077

which raises a key error if there are no talos suites defined.  This should be moved inside the loop through SUITES.  Also, since talosCmd is only used once, don't use a separate variable.
(Assignee)

Comment 1

6 years ago
Created attachment 615169 [details] [diff] [review]
proposed patch

Builds are running successfully with this patch applied on http://dev-master01.build.scl1.mozilla.com:8900/
Attachment #615169 - Flags: review?(bhearsum)
Attachment #615169 - Flags: review?(bhearsum) → review+
This can land in the main buildbotcustom repo anytime.
(Assignee)

Comment 3

6 years ago
Comment on attachment 615169 [details] [diff] [review]
proposed patch

Review of attachment 615169 [details] [diff] [review]:
-----------------------------------------------------------------

Landed in http://hg.mozilla.org/build/buildbotcustom/rev/ae41eceacb0b
Attachment #615169 - Flags: checked-in+
deployed in today's reconfig
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.