745557 - add-on release notes fail to load

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[al_9x]

1. Fx 12.0b5 & 14.0a1 (2012-04-15)
2. new profile
3. turn off automatic add-on updates
4. install an older version of an add-on
5. perform update check
6. in the available updates list click on show release notes
7. "Sorry, there was an error loading the release notes"

e.g. https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/

Comment 1

[Kurt Pruenner]

I'm having the same problem running Aurora (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120421 Firefox/13.0a2); any add-on I try to show the release notes for in the "Available updates" list gives me "Sorry, but there was an error loading the release notes".

Using Fiddler2, I was able to capture the request Firefox makes, and I can't really find anything out of the ordinary - I'll attach it (minus the cookies header) in case it can help...

Comment 2

[Kurt Pruenner]

Attachment: Release notes request as captured by Fiddler2

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can confirm this.
When I try to load the release notes for Status 4 Evar, I see the following requests go out:
[01:23:15.443] GET https://addons.mozilla.org/versions/updateInfo/1331804/en-US/ [HTTP/1.1 301 MOVED PERMANENTLY 1494ms]
[01:23:16.913] GET https://addons.mozilla.org/en-US/firefox/versions/updateInfo/1331804/en-US/ [HTTP/1.1 301 MOVED PERMANENTLY 141ms]
[01:23:17.066] GET https://addons.mozilla.org/en-US/firefox/addon/235283/versions/2012.04.21.13/updateinfo/ [HTTP/1.1 301 MOVED PERMANENTLY 249ms]
[01:23:17.326] GET https://addons.mozilla.org/en-US/firefox/addon/status-4-evar/versions/2012.04.21.13/updateinfo/ [HTTP/1.1 200 OK 496ms]


If I load the final requested URL manually, I see the release notes.

Does it give up displaying the notes after a certain number of redirects or something, even though the redirected requests still go out and finally resolve on the correct URL?

Comment 4

[MozillaUser233]

This has been happening for a few weeks now, more like a month straight, then sometime this week it stopped, and today it started up again with the same error.

Comment 5

[Kurt Pruenner]

I just re-checked with the update for IE View - it didn't go through a single redirect (i.e. it requested https://addons.mozilla.org/en-US/firefox/addon/ie-view/versions/1.5.1/updateinfo/ directly), but it still failed.

I'll attach another capture.

Comment 6

[Kurt Pruenner]

Attachment: Another release notes request (for IEView this time) captured with Fiddler2

Comment 7

[Dave Townsend [:mossop]]

I think the problem is the unclosed <br> tag. That's certainly something that was a problem in the past so I suspect AMO's side has changed here. We do have proper html parsing in XHR now so maybe we could just enable that and get rid of the annoying dependency on valid xml from this though.

Comment 8

[Matthew N. [:MattN]]

This is broken because AMO is now returning a text/html content-type so it fails this:
>            if ((!ct || ct.indexOf("text/html") < 0) &&
>                req.responseXML &&
>                req.responseXML.documentElement.namespaceURI != XMLURI_PARSE_ERROR) {


WIP untested commit here: https://github.com/mnoorenberghe/zamboni/commit/ff86e74fee06809981019b6eca4a6e9c975eb7fe

Comment 9

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/643332a

Joint patch by Matt and cvan - thanks, Matt!

Will go live in production on Thurs, May 3.

Comment 10

[Matthew N. [:MattN]]

Verified that release notes are working again.

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:15.0) Gecko/15.0 Firefox/15.0a1