Last Comment Bug 745568 - Fix nsXULDocument::CloneNode
: Fix nsXULDocument::CloneNode
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks: buildwarning 698381
  Show dependency treegraph
 
Reported: 2012-04-15 14:02 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-05-05 10:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.26 KB, patch)
2012-04-15 14:02 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-04-15 14:02:57 PDT
Created attachment 615189 [details] [diff] [review]
Patch v1

I hate C++.
Comment 1 Olli Pettay [:smaug] (TPAC) 2012-04-16 00:20:23 PDT
Comment on attachment 615189 [details] [diff] [review]
Patch v1

>--- a/content/xul/document/src/nsXULDocument.h
>+++ b/content/xul/document/src/nsXULDocument.h
>@@ -53,16 +53,18 @@
> #include "nsIDOMXULDocument.h"
> #include "nsCOMArray.h"
> #include "nsIURI.h"
> #include "nsIXULDocument.h"
> #include "nsScriptLoader.h"
> #include "nsIStreamListener.h"
> #include "nsICSSLoaderObserver.h"
> 
>+#include "mozilla/Attributes.h"
>+
Er, why this?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-04-16 00:57:00 PDT
For the MOZ_OVERRIDE bit
Comment 3 Olli Pettay [:smaug] (TPAC) 2012-04-16 01:05:22 PDT
huh, what a terribly named header file.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-05-05 10:27:21 PDT
https://hg.mozilla.org/mozilla-central/rev/7c40d16cbb1f

Note You need to log in before you can comment on or make changes to this bug.