OAuth dialog url and secure icon not vertically aligned properly

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
x86
All
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(5 attachments, 5 obsolete attachments)

Created attachment 615418 [details]
Problem on Windows 7 Aero

On Windows 7, XP and on OSX, the little green circle icon and the URL seem to be misaligned.  See screenshots.
OS: Windows 7 → All
Created attachment 615420 [details]
Problem on Windows XP
Created attachment 615422 [details]
Problem on OSX
(Assignee)

Comment 3

5 years ago
Created attachment 615447 [details] [diff] [review]
Fix

The description (the URL) has a margin-bottom of 4px but on top only 1px. This patch gives on top a margin of 3px. This centers the text better and also the secure icon. When I give on bottom a margin of 3px the icon is no more centered.
On Mac I changed the useless padding-right: 5px to a working margin-right: 5px to give a gap between icon and text.
Attachment #615447 - Flags: review?(mconley)
(Assignee)

Comment 4

5 years ago
Created attachment 615448 [details] [diff] [review]
Fix

Oops a tab instead of spaces slipped in.
Attachment #615448 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Attachment #615447 - Attachment is obsolete: true
Attachment #615447 - Flags: review?(mconley)
Created attachment 615718 [details]
Fix on Ubuntu

Hey Paenglab,

Thanks for tackling this!  I've noticed that the icon is still not exactly centered vertically on Ubuntu.  See screenshot. Care to tweak it?

-Mike
(Assignee)

Comment 6

5 years ago
Created attachment 615750 [details] [diff] [review]
Fix 2nd try

This should be better.
Assignee: nobody → richard.marti
Attachment #615448 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #615448 - Flags: review?(mconley)
Attachment #615750 - Flags: review?(mconley)
Created attachment 615787 [details]
Fix 2nd try on Windows 7 Aero

Paenglab,

So OSX, Ubuntu, and Windows XP / Classic all look great now.

Windows Aero still looks a bit off.  See screenshot.

-Mike
Attachment #615718 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Created attachment 615810 [details] [diff] [review]
Fix v3

Added browserRequest-aero.css to fix the differences between XP and Win7.
Attachment #615750 - Attachment is obsolete: true
Attachment #615750 - Flags: review?(mconley)
Attachment #615810 - Flags: review?(mconley)
Comment on attachment 615810 [details] [diff] [review]
Fix v3

Review of attachment 615810 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Paenglab - looks great!

Just one nit.  Once fixed, r=me.

::: mail/themes/pinstripe/mail/browserRequest.css
@@ +75,5 @@
>      font-weight: normal;
>  }
> +
> +#headerMessage {
> +    margin-top: 3px;

These should be indented 2 spaces, not 4.
Attachment #615810 - Flags: review?(mconley) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 615861 [details] [diff] [review]
Patch for check-in addressing comment

Patch addressing review

Carrying over r+
Attachment #615810 - Attachment is obsolete: true
Attachment #615861 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/db79074493e3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 615861 [details] [diff] [review]
Patch for check-in addressing comment

We want this for Filelink.
Attachment #615861 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #615861 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/a1a9b3984c5a
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.