745879 - OAuth dialog url and secure icon not vertically aligned properly

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Problem on Windows 7 Aero

On Windows 7, XP and on OSX, the little green circle icon and the URL seem to be misaligned.  See screenshots.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Problem on Windows XP

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Problem on OSX

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Fix

The description (the URL) has a margin-bottom of 4px but on top only 1px. This patch gives on top a margin of 3px. This centers the text better and also the secure icon. When I give on bottom a margin of 3px the icon is no more centered.
On Mac I changed the useless padding-right: 5px to a working margin-right: 5px to give a gap between icon and text.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Fix

Oops a tab instead of spaces slipped in.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fix on Ubuntu

Hey Paenglab,

Thanks for tackling this!  I've noticed that the icon is still not exactly centered vertically on Ubuntu.  See screenshot. Care to tweak it?

-Mike

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Fix 2nd try

This should be better.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fix 2nd try on Windows 7 Aero

Paenglab,

So OSX, Ubuntu, and Windows XP / Classic all look great now.

Windows Aero still looks a bit off.  See screenshot.

-Mike

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Fix v3

Added browserRequest-aero.css to fix the differences between XP and Win7.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 615810 [details] [diff] [review]
Fix v3

Review of attachment 615810 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Paenglab - looks great!

Just one nit.  Once fixed, r=me.

::: mail/themes/pinstripe/mail/browserRequest.css
@@ +75,5 @@
>      font-weight: normal;
>  }
> +
> +#headerMessage {
> +    margin-top: 3px;

These should be indented 2 spaces, not 4.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in addressing comment

Patch addressing review

Carrying over r+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/db79074493e3

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 615861 [details] [diff] [review]
Patch for check-in addressing comment

We want this for Filelink.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/a1a9b3984c5a