Closed Bug 745879 Opened 9 years ago Closed 9 years ago

OAuth dialog url and secure icon not vertically aligned properly

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: mconley, Assigned: Paenglab)

References

Details

Attachments

(5 files, 5 obsolete files)

On Windows 7, XP and on OSX, the little green circle icon and the URL seem to be misaligned.  See screenshots.
OS: Windows 7 → All
Attached image Problem on OSX
Attached patch Fix (obsolete) — Splinter Review
The description (the URL) has a margin-bottom of 4px but on top only 1px. This patch gives on top a margin of 3px. This centers the text better and also the secure icon. When I give on bottom a margin of 3px the icon is no more centered.
On Mac I changed the useless padding-right: 5px to a working margin-right: 5px to give a gap between icon and text.
Attachment #615447 - Flags: review?(mconley)
Attached patch Fix (obsolete) — Splinter Review
Oops a tab instead of spaces slipped in.
Attachment #615448 - Flags: review?(mconley)
Attachment #615447 - Attachment is obsolete: true
Attachment #615447 - Flags: review?(mconley)
Attached image Fix on Ubuntu (obsolete) —
Hey Paenglab,

Thanks for tackling this!  I've noticed that the icon is still not exactly centered vertically on Ubuntu.  See screenshot. Care to tweak it?

-Mike
Attached patch Fix 2nd try (obsolete) — Splinter Review
This should be better.
Assignee: nobody → richard.marti
Attachment #615448 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #615448 - Flags: review?(mconley)
Attachment #615750 - Flags: review?(mconley)
Paenglab,

So OSX, Ubuntu, and Windows XP / Classic all look great now.

Windows Aero still looks a bit off.  See screenshot.

-Mike
Attachment #615718 - Attachment is obsolete: true
Attached patch Fix v3 (obsolete) — Splinter Review
Added browserRequest-aero.css to fix the differences between XP and Win7.
Attachment #615750 - Attachment is obsolete: true
Attachment #615750 - Flags: review?(mconley)
Attachment #615810 - Flags: review?(mconley)
Comment on attachment 615810 [details] [diff] [review]
Fix v3

Review of attachment 615810 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Paenglab - looks great!

Just one nit.  Once fixed, r=me.

::: mail/themes/pinstripe/mail/browserRequest.css
@@ +75,5 @@
>      font-weight: normal;
>  }
> +
> +#headerMessage {
> +    margin-top: 3px;

These should be indented 2 spaces, not 4.
Attachment #615810 - Flags: review?(mconley) → review+
Patch addressing review

Carrying over r+
Attachment #615810 - Attachment is obsolete: true
Attachment #615861 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/db79074493e3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 615861 [details] [diff] [review]
Patch for check-in addressing comment

We want this for Filelink.
Attachment #615861 - Flags: approval-comm-aurora?
Attachment #615861 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.