745885 - CommonUtils.namedTimer support for different timer types

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Gregory Szorc [:gps]]

CommonUtils.namedTimer currently uses one shot timers and only one shot timers. I'd like to add an argument to support specifying the timer type.

Comment 1

[Gregory Szorc [:gps]]

Attachment: namedTimer improvements, v1

Added support for arbitrary types. Also fixed style nits. Also fixed unit tests which called run_next_test() twice. Seriously.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 615516 [details] [diff] [review]
namedTimer improvements, v1

Review of attachment 615516 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/test_utils_namedTimer.js
@@ +64,5 @@
> +    if (count < 2) {
> +      return;
> +    }
> +
> +    do_check_true((Date.now() - t0) > 2 * delay);

Can you assign these two quantities to named locals for clarity?

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/df780dfa7862

Comment 4

[Gregory Szorc [:gps]]

xpcshell tests failing on Windows and Linux with this patch applied. Not OS X, however.

Comment 5

[Gregory Szorc [:gps]]

Backed out: https://hg.mozilla.org/services/services-central/rev/e7023f51768c

Comment 6

[Tracy Walker [:tracy]]

[qa-] but I will be smoketesting Sync on s-c to be certain nothing is broken.

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/df780dfa7862
https://hg.mozilla.org/mozilla-central/rev/e7023f51768c