745982 - [AccessFu] Move BORDER_PADDING to VisualPresenter

Status: RESOLVED FIXED

Description

[Eitan Isaacson [:eeejay]]

I put it my mistake in the base class.

Comment 1

[Eitan Isaacson [:eeejay]]

Created attachment 615503 [details] [diff] [review]
Move border padding to visual presenter, oops.

Comment 2

[alexander :surkov]

Comment on attachment 615503 [details] [diff] [review]
Move border padding to visual presenter, oops.

Review of attachment 615503 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/Presenters.jsm
@@ +93,5 @@
>  
> +/**
> + * The padding in pixels between the object and the highlight border.
> + */
> +VisualPresenter.prototype.BORDER_PADDING = 2;

I don't recall whether I said that or just though about that but keeping padding value in js is weird. It should live in CSS. I think you could get it back from element when you calculate things like:
left: Math.round((objX.value - docX.value - this.BORDER_PADDING) * aZoom),

but of course keeping it in VisualPresenter is more correct, so r=me

Comment 3

[Eitan Isaacson [:eeejay]]

I agree. It gets a bit tricky to get the CSS value in Javascript. Also, CSS values are expected to be handled by layout, and not programatically by us. I'll land this for now though.

Comment 4

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4a5d25e138e2

Comment 5

[Ed Morley (Away 27th-2nd) [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a5d25e138e2