Alarm service should ignore alarms on added and modified items outside the alarm search range

RESOLVED FIXED in 1.6

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mmecca, Assigned: mmecca)

Tracking

(Blocks 3 bugs)

unspecified
Dependency tree / graph

Details

Attachments

(1 attachment)

We currently search for alarms at startup on items within the range of +/- one month, but added and modified non-repeating items are not checked against this range. Checking these items against the same range should lessen the impact of the past alarm issues (see Bug 496889, Bug 466871, Bug 349673, Bug 276585).
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Posted patch Fix v1Splinter Review
Checks if non-repeating items are within alarm range.
Attachment #615600 - Flags: review?(philipp)
Comment on attachment 615600 [details] [diff] [review]
Fix v1

Looks good, r=philipp.

Maybe you are interested in creating some unit tests for the alarm service in another bug?
Attachment #615600 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Maybe you are interested in creating some unit tests for the alarm service
> in another bug?

Filed Bug 746434
Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/a73bde329a9f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.