Closed
Bug 746048
Opened 14 years ago
Closed 14 years ago
Alarm service should ignore alarms on added and modified items outside the alarm search range
Categories
(Calendar :: Alarms, defect)
Calendar
Alarms
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: mmecca, Assigned: mmecca)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
We currently search for alarms at startup on items within the range of +/- one month, but added and modified non-repeating items are not checked against this range. Checking these items against the same range should lessen the impact of the past alarm issues (see Bug 496889, Bug 466871, Bug 349673, Bug 276585).
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 1•14 years ago
|
||
Checks if non-repeating items are within alarm range.
Attachment #615600 -
Flags: review?(philipp)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 615600 [details] [diff] [review]
Fix v1
Looks good, r=philipp.
Maybe you are interested in creating some unit tests for the alarm service in another bug?
Attachment #615600 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Maybe you are interested in creating some unit tests for the alarm service
> in another bug?
Filed Bug 746434
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/a73bde329a9f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•