74606 - Cannot change drives when using the filepicker.xul dialog

Status: VERIFIED WONTFIX

(SeaMonkey :: UI Design, defect)

Description

[Jessica Blanco]

You cannot change drives when using the filepicker dialog 
(filepicker.xul). Cannot open a file from a different drive 
or save to a different drive than what the filepicker opens 
up with. Happens on all OSes using filepicker.xul.

Comment 1

[timeless]

bryner is rewriting this dialog, however i don't think anyone even thought 
about this problem (windows uses native file picker)

Comment 2

[sairuh (rarely reading bugmail)]

would this occur on unix? on linux, eg, i don't have a problem opening or saving
to different *partitions*, at least... perhaps this is os/2-specific?

Comment 3

[timeless]

yes, well, it's basically os/2 specific (hence os/platform), however if we ever 
switch windows to xp filepicker, it'd appear there, I have no idea about mac (i 
hope we use nav services and avoid the issue).

mkaply: I don't remember the reason you guys didn't use a native filepicker, 
could you tell us?

Comment 4

[Brian Ryner (not reading)]

I don't think there's time for this for 0.9.  mkaply, do you think you could
help on this one?

Comment 5

[Mike Kaply [:mkaply]]

This one is on our radar. We would certainly like to use the XP file picker on 
OS/2 in the future.

We do have a native filepicker. Unfortunately though when we switched widget to 
use proper component registration instead of nsSetupRegistry, we started getting 
the XP filepicker instead of the native filepicker.

Relevant code is at:

http://lxr.mozilla.org/seamonkey/source/widget/src/os2/nsWidgetFactory.cpp#252

We believe it's probably a timing issue.

For 0.9, we will simply not package nsFilePicker.js so the problem won't happen, 
but does anyone have any idea how you force one component over another in 
component registration?

Or should we not be putting nsFilePicker.js in components for OS/2 until we get 
it working?

Comment 6

[Brian Ryner (not reading)]

I would simply change xpfe/components/filepicker/Makefile.in to not go into the
src directory (for OS2) if you don't want the xp filepicker to be used.  Trying
to make components override each other sounds like it's asking for problems.

Comment 7

[Mike Kaply [:mkaply]]

Silly question

Should I change filepicker/Makefile.in? Or should I just change the components 
makefile to not go into the filepicker directory at all?

Or maybe we should add a configure option for the XP filepicker?

Comment 8

[Brian Ryner (not reading)]

Windows goes into filepicker/res/locale, so that it can install the properties
file... you'll probably want to do the same.

Comment 9

[Jessica Blanco]

*** Bug 77577 has been marked as a duplicate of this bug. ***

Comment 10

[Mike Kaply [:mkaply]]

Attachment: Don't go into src on OS/2

Comment 11

[cls]

r=cls

Comment 12

[Brian Ryner (not reading)]

Pushing this out, we have no plans to turn on the xul filepicker on any non-unix
platforms in the 0.9.3 timeframe.

Comment 13

[Brian Ryner (not reading)]

using the xul filepicker for non-unix systems really isn't a high priority...

Comment 14

[Mike Kaply [:mkaply]]

Brian,

Do you think this is something we will ever want for any platform besides OS/2?

If not, we can kill this bug - we rewrote our file picker on OS/2 and it works 
very well so we don't need to use the XP one anymore.

Comment 15

[Brian Ryner (not reading)]

doubtful.  let's kill it.

Comment 16

[Mike Kaply [:mkaply]]

Verify. we don't need this anymore.