74608 - Problems with named anchors on roadmap

Status: VERIFIED FIXED

(mozilla.org :: Miscellaneous, task)

Description

[Jesse Ruderman]

Some of these problems are easier to see after running the named anchors 
bookmarklet on the page (http://www.mozilla.org/roadmap.html).
<http://www.squarefree.com/bookmarklets/powersurfing.html#show_named_anchors>

- The first few sections of the roadmap don't have anchors.  This prevents me 
from giving someone a quick link to the "branch details" image, for example.
- Several <h2>'s are inside <a>'s.  I don't think that's good html, since <h2> 
is a block element, and <a> is an inline element.  I think the anchors should 
be inside the <h2>s, and either contain the text in the <h2> or be empty and 
before the text.
- The anchor for "code review" has an unnecessary "#".  I guess it could be 
left like that, but it shows up when I run the "show named anchors" bookmarklet 
and looks weird when linked to (double # sign).
- The "new milestones" anchor includes the entire table.  This might be ok 
html, but it's kinda weird.  The anchor should probably be before the table.

Comment 1

[Brendan Eich [:brendan]]

Fixed, finally!

/be

Comment 2

[Jesse Ruderman]

The named anchors are now before the headers.  This is better, but it still
doesn't look quite right with the named anchors bookmarklet, because each
anchors appears as being part of the paragraph above the header.

Comment 3

[Brendan Eich [:brendan]]

Suggestion?  I couldn't get the named anchor bookmarklet to work on Linux 0.9.3,
so I'm not happy guessing and trying again.  Please feel free to spoon-feed me a
change that works, and I'll check it in.

/be

Comment 4

[Jesse Ruderman]

For the headers:
<h2 align=center><a name="how-you-can-help">how you can help</a></h2>

For the table, put the named anchor at the beginning of the paragraph above the
table, or just leave it where it is.

(Btw, I was able to use the named anchors bookmarklet on Hixie's linux computer,
which has an old build of Mozilla on it.)

Comment 5

[Brendan Eich [:brendan]]

Ok, thanks (I flubbed some closing </a> tags, duping them).  All better, I hope
-- lemme know.

/be

Comment 6

[Daniel Wang]

mass verify