Last Comment Bug 746087 - Implement HTML5 toolbar menus
: Implement HTML5 toolbar menus
Status: NEW
[tw-dom]
: dev-doc-needed
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: All All
: -- normal with 16 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on: 897102 617528
Blocks: html5 html5test
  Show dependency treegraph
 
Reported: 2012-04-17 01:48 PDT by Jan Varga [:janv]
Modified: 2016-05-08 09:05 PDT (History)
22 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
screenshot (215.26 KB, image/png)
2012-05-01 07:09 PDT, Jan Varga [:janv]
no flags Details
more recent screenshot (205.96 KB, image/png)
2012-05-01 07:33 PDT, Jan Varga [:janv]
no flags Details
WIP patch (20.97 KB, patch)
2012-05-01 08:30 PDT, Jan Varga [:janv]
no flags Details | Diff | Review

Description Jan Varga [:janv] 2012-04-17 01:48:19 PDT

    
Comment 1 Jan Varga [:janv] 2012-04-17 02:56:51 PDT
Should this implementation follow the proposal at https://www.w3.org/Bugs/Public/show_bug.cgi?id=13608#c6 ?

So the syntax would be:
<toolbar>
  <toolbarbutton>
  <toolbarbutton>
  ...
</toolbar>
Comment 2 Masatoshi Kimura [:emk] 2012-04-17 02:59:54 PDT
Adding yet another random unspec'ed tag? Browser wars came again!
Comment 3 Jan Varga [:janv] 2012-04-17 03:02:13 PDT
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Adding yet another random unspec'ed tag? Browser wars came again!

No, we're going to discuss about it first
Comment 4 Jan Varga [:janv] 2012-04-17 03:03:28 PDT
anyway, the <menuitem> is not in the standard :)
Comment 5 Masatoshi Kimura [:emk] 2012-04-17 03:17:26 PDT
(In reply to Jan Varga [:janv] from comment #3)
> (In reply to Masatoshi Kimura [:emk] from comment #2)
> > Adding yet another random unspec'ed tag? Browser wars came again!
> No, we're going to discuss about it first
And it appears that a spec editor oppose adding <menuitem>. Moreover, the spec bug was filed after Henri pointed out in bug 676236 comment #2.
(In reply to Jan Varga [:janv] from comment #4)
> anyway, the <menuitem> is not in the standard :)
Then making things even worse?
Comment 6 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-04-17 03:20:25 PDT
(In reply to Masatoshi Kimura [:emk] from comment #5)
> And it appears that a spec editor oppose adding <menuitem>.
So? If the spec is bad, it should be changed.
Comment 7 Jan Varga [:janv] 2012-05-01 07:09:18 PDT
Created attachment 619915 [details]
screenshot

here's an old screenshot, will attach a new one and also a WIP patch
Comment 8 Jan Varga [:janv] 2012-05-01 07:33:20 PDT
Created attachment 619921 [details]
more recent screenshot
Comment 9 Jan Varga [:janv] 2012-05-01 08:30:09 PDT
Created attachment 619936 [details] [diff] [review]
WIP patch
Comment 10 Tim Nguyen :ntim 2013-12-30 04:42:10 PST
The spec changes a little bit, menuitem is back I guess. menu[type="context"] is now menu[type="popup"] same for <menu>
Comment 11 Florian Bender 2013-12-31 09:22:12 PST
Tim, see Bug 897102.
Comment 12 Jan Varga [:janv] 2014-01-06 13:23:03 PST
Yeah, the spec has changed (mostly the way we wanted), but unfortunately updating our implementation is not a priority at the moment :(
Comment 13 Tim Nguyen :ntim 2016-02-25 13:03:15 PST
Jan, any chance you can resume development on this bug? This has gotten much more relevant, especially in the light of XUL deprecation, and it'll allow many parts of the UI to be rewritten in HTML (Developer Tools for example).
Comment 14 Jan Varga [:janv] 2016-03-02 00:02:44 PST
(In reply to Tim Nguyen [:ntim] from comment #13)
> Jan, any chance you can resume development on this bug? This has gotten much
> more relevant, especially in the light of XUL deprecation, and it'll allow
> many parts of the UI to be rewritten in HTML (Developer Tools for example).

I don't have the time currently, but maybe someone else from the DOM team could take it.
Comment 15 Jonas Sicking (:sicking) PTO Until July 5th 2016-03-08 22:56:54 PST
I'm not convinced this bug is worth fixing. At the very least we should check that other browsers are interested before we implement anything. If we end up being the only one implementing, developers are very unlikely to use this.
Comment 16 Andrew Overholt [:overholt] 2016-03-09 00:36:16 PST
(In reply to Jonas Sicking (:sicking) from comment #15)
> I'm not convinced this bug is worth fixing. At the very least we should
> check that other browsers are interested before we implement anything. If we
> end up being the only one implementing, developers are very unlikely to use
> this.

Sure.
Comment 17 Marco Zehe (:MarcoZ) 2016-03-09 03:22:47 PST
According to http://html5accessibility.com/, we support menuitem, and partially menu popups, and we're the only ones doing so. If we implemented this fully, it would give us an edge and maybe entice others to follow our lead, alleviating the need for ugly hacks web developers need to implement nowadays for such menu systems.
Comment 18 alexander :surkov 2016-03-09 06:02:59 PST
(In reply to Jonas Sicking (:sicking) from comment #15)
> If we
> end up being the only one implementing, developers are very unlikely to use
> this.

If a feature is wanted and its implementation was decent then wouldn't developers prefer to create polyfills, that seems to be less painful than to implement a feature for all browsers from scratch.
Comment 19 Stephan Sokolow 2016-03-27 20:50:51 PDT
(In reply to Jonas Sicking (:sicking) from comment #15)
> I'm not convinced this bug is worth fixing. At the very least we should
> check that other browsers are interested before we implement anything. If we
> end up being the only one implementing, developers are very unlikely to use
> this.

If it helps, other browsers are finally stirring on the context menu support that Firefox has had for a while.

Chrome's got an implementation of the context menu support but it's being held behind an experimental feature flag because they followed the spec more closely than Firefox, it broke a site, and discussions on changing the spec apparently went nowhere.

https://bugs.chromium.org/p/chromium/issues/detail?id=87553 (implementation)
https://bugs.chromium.org/p/chromium/issues/detail?id=412945 (site evangelism bug)

I don't know how accurate it is, but caniuse.com claims that Opera inherited that ability by their use of Blink:

http://caniuse.com/#feat=menu

As for Edge, there's a UserVoice request to support it and Microsoft has the feature listed as under consideration (probably because of the aforementioned issue Chrome ran into).

https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6508881-html5-menu-tag-contextmenu-attribute
https://dev.windows.com/en-us/microsoft-edge/platform/status/menuelement

Note You need to log in before you can comment on or make changes to this bug.