FileLink prefs gets a empty space on the right if Lightning is installed

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Unassigned)

Tracking

Trunk
Thunderbird 14.0
x86_64
Windows 7
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

5 years ago
Actually, the way it seem to work, it gains a extra space if any extension that grows the preferences pane width in any way (like adding a new icon on the top) gets installed.

The fix seems to be to not specify the width of #provider-management
(Reporter)

Comment 1

5 years ago
Created attachment 615916 [details] [diff] [review]
patch (v1)

Haven't figured out how to make the "view account settings" link go on the bottom yet, but Mike will love me anyway, as I'm making the hardcoded pixel values go poof.
(Reporter)

Comment 2

5 years ago
Created attachment 616087 [details] [diff] [review]
patch (v2)

This also positions the text correctly.
Attachment #615916 - Attachment is obsolete: true
Attachment #616087 - Flags: ui-review?(bwinton)
Attachment #616087 - Flags: review?(mconley)
Comment on attachment 616087 [details] [diff] [review]
patch (v2)

Review of attachment 616087 [details] [diff] [review]:
-----------------------------------------------------------------

Does this only apply to qute?  I wouldn't be surprised if the problem was the same in pinstripe / gnomestripe...

Updated

5 years ago
Blocks: 698925

Updated

5 years ago
Depends on: 746554
It doesn't appear for me in pinstripe…
Agreed - and I don't see it in gnomestripe either.

Regardless, I think it'd be a good idea to excise the hard-coded dimensions from those two themes as well.
Comment on attachment 616087 [details] [diff] [review]
patch (v2)

I agree.  Andreas, can you post a patch that does the same for all the themes, and I'll give it the full ui-review treatment then?

Thanks,
Blake.
Attachment #616087 - Flags: ui-review?(bwinton)
Attachment #616087 - Flags: review?(mconley)
(Reporter)

Comment 7

5 years ago
Sure. Seems I've ran into a slight bitrot (locally) so I'll post a patch once I've settled that.
As a side note, I just checked it out in Windows Aero, and I think that there's too much space on the left portion of the space display.  Could you even it out a bit, so that it's something like:

[space] Used/Unused [space] Pretty Circle

?

Thanks,
Blake.

Updated

5 years ago
Blocks: 746725
(Reporter)

Comment 9

5 years ago
Created attachment 617354 [details] [diff] [review]
patch (v3)

For gnomestripe and pinstripe as well.
Andreas:

Are these ready for review?

-Mike
(Reporter)

Comment 11

5 years ago
Created attachment 617504 [details] [diff] [review]
patch (v4)

This gives some space between the chart and the numbers.
Attachment #616087 - Attachment is obsolete: true
Attachment #617354 - Attachment is obsolete: true
Attachment #617504 - Flags: ui-review?(bwinton)
Attachment #617504 - Flags: review?(mconley)
Created attachment 617531 [details]
Fix on Ubuntu
Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Review of attachment 617504 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, it's so good to see those hard-coded dimensions disappear. :)

Thanks for your work Andreas - this code looks good to me.

-Mike
Attachment #617504 - Flags: review?(mconley) → review+
(Reporter)

Comment 14

5 years ago
Created attachment 617541 [details]
screenshot of the fix on OS X
Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Based on the screenshots, ui-r=me!

Thanks,
Blake.
Attachment #617504 - Flags: ui-review?(bwinton) → ui-review+
(Reporter)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Attachment #617504 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/80e0310cd63c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

5 years ago
Attachment #617504 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/bbd6494a2ec4
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.