746307 - FileLink prefs gets a empty space on the right if Lightning is installed

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Andreas Nilsson (:andreasn)]

Actually, the way it seem to work, it gains a extra space if any extension that grows the preferences pane width in any way (like adding a new icon on the top) gets installed.

The fix seems to be to not specify the width of #provider-management

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch (v1)

Haven't figured out how to make the "view account settings" link go on the bottom yet, but Mike will love me anyway, as I'm making the hardcoded pixel values go poof.

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: patch (v2)

This also positions the text correctly.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 616087 [details] [diff] [review]
patch (v2)

Review of attachment 616087 [details] [diff] [review]:
-----------------------------------------------------------------

Does this only apply to qute?  I wouldn't be surprised if the problem was the same in pinstripe / gnomestripe...

Comment 4

[Blake Winton (:bwinton) (:☕️)]

It doesn't appear for me in pinstripe…

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Agreed - and I don't see it in gnomestripe either.

Regardless, I think it'd be a good idea to excise the hard-coded dimensions from those two themes as well.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 616087 [details] [diff] [review]
patch (v2)

I agree.  Andreas, can you post a patch that does the same for all the themes, and I'll give it the full ui-review treatment then?

Thanks,
Blake.

Comment 7

[Andreas Nilsson (:andreasn)]

Sure. Seems I've ran into a slight bitrot (locally) so I'll post a patch once I've settled that.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

As a side note, I just checked it out in Windows Aero, and I think that there's too much space on the left portion of the space display.  Could you even it out a bit, so that it's something like:

[space] Used/Unused [space] Pretty Circle

?

Thanks,
Blake.

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: patch (v3)

For gnomestripe and pinstripe as well.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Andreas:

Are these ready for review?

-Mike

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: patch (v4)

This gives some space between the chart and the numbers.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fix on Ubuntu

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Review of attachment 617504 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, it's so good to see those hard-coded dimensions disappear. :)

Thanks for your work Andreas - this code looks good to me.

-Mike

Comment 14

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of the fix on OS X

Comment 15

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Based on the screenshots, ui-r=me!

Thanks,
Blake.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/80e0310cd63c

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/bbd6494a2ec4