FileLink prefs gets a empty space on the right if Lightning is installed

RESOLVED FIXED in Thunderbird 14.0

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: andreasn, Unassigned)

Tracking

Trunk
Thunderbird 14.0
x86_64
Windows 7
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Reporter

Description

7 years ago
Actually, the way it seem to work, it gains a extra space if any extension that grows the preferences pane width in any way (like adding a new icon on the top) gets installed.

The fix seems to be to not specify the width of #provider-management
Reporter

Comment 1

7 years ago
Posted patch patch (v1) (obsolete) — Splinter Review
Haven't figured out how to make the "view account settings" link go on the bottom yet, but Mike will love me anyway, as I'm making the hardcoded pixel values go poof.
Reporter

Comment 2

7 years ago
Posted patch patch (v2) (obsolete) — Splinter Review
This also positions the text correctly.
Attachment #615916 - Attachment is obsolete: true
Attachment #616087 - Flags: ui-review?(bwinton)
Attachment #616087 - Flags: review?(mconley)
Comment on attachment 616087 [details] [diff] [review]
patch (v2)

Review of attachment 616087 [details] [diff] [review]:
-----------------------------------------------------------------

Does this only apply to qute?  I wouldn't be surprised if the problem was the same in pinstripe / gnomestripe...
It doesn't appear for me in pinstripe…
Agreed - and I don't see it in gnomestripe either.

Regardless, I think it'd be a good idea to excise the hard-coded dimensions from those two themes as well.
Comment on attachment 616087 [details] [diff] [review]
patch (v2)

I agree.  Andreas, can you post a patch that does the same for all the themes, and I'll give it the full ui-review treatment then?

Thanks,
Blake.
Attachment #616087 - Flags: ui-review?(bwinton)
Attachment #616087 - Flags: review?(mconley)
Reporter

Comment 7

7 years ago
Sure. Seems I've ran into a slight bitrot (locally) so I'll post a patch once I've settled that.
As a side note, I just checked it out in Windows Aero, and I think that there's too much space on the left portion of the space display.  Could you even it out a bit, so that it's something like:

[space] Used/Unused [space] Pretty Circle

?

Thanks,
Blake.
Reporter

Comment 9

7 years ago
Posted patch patch (v3) (obsolete) — Splinter Review
For gnomestripe and pinstripe as well.
Andreas:

Are these ready for review?

-Mike
Reporter

Comment 11

7 years ago
Posted patch patch (v4)Splinter Review
This gives some space between the chart and the numbers.
Attachment #616087 - Attachment is obsolete: true
Attachment #617354 - Attachment is obsolete: true
Attachment #617504 - Flags: ui-review?(bwinton)
Attachment #617504 - Flags: review?(mconley)
Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Review of attachment 617504 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, it's so good to see those hard-coded dimensions disappear. :)

Thanks for your work Andreas - this code looks good to me.

-Mike
Attachment #617504 - Flags: review?(mconley) → review+
Comment on attachment 617504 [details] [diff] [review]
patch (v4)

Based on the screenshots, ui-r=me!

Thanks,
Blake.
Attachment #617504 - Flags: ui-review?(bwinton) → ui-review+
Reporter

Updated

7 years ago
Keywords: checkin-needed
Attachment #617504 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/80e0310cd63c
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

7 years ago
Attachment #617504 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.