Last Comment Bug 746309 - Filelink uploads started from the offer notification bar has broken interaction
: Filelink uploads started from the offer notification bar has broken interaction
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Mike Conley (:mconley) - (Needinfo me!)
:
Mentors:
Depends on:
Blocks: BigFiles
  Show dependency treegraph
 
Reported: 2012-04-17 13:31 PDT by Mike Conley (:mconley) - (Needinfo me!)
Modified: 2012-04-18 11:51 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Patch v1 (3.92 KB, patch)
2012-04-17 14:29 PDT, Mike Conley (:mconley) - (Needinfo me!)
mozilla: review+
mozilla: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (Needinfo me!) 2012-04-17 13:31:32 PDT
STR:

1)  Open a compose window, attach some files
2)  Choose to link the files, and create a new Filelink account with some provider

What happens?

The upload begins, but no notification bar comes up to tell us that links will be inserted into the body of the message.  What's more, the offer notification comes back up again.

What's expected?

The opposite of the above.
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-04-17 13:47:13 PDT
Ack, a typo slipped in to the patch for bug 738299.  I've found the issue - going to try to put together a test for it too.
Comment 2 Mike Conley (:mconley) - (Needinfo me!) 2012-04-17 14:29:09 PDT
Created attachment 615874 [details] [diff] [review]
Patch v1

This fixes things, and I added a test.
Comment 3 David :Bienvenu 2012-04-18 09:34:42 PDT
Comment on attachment 615874 [details] [diff] [review]
Patch v1

[Triage Comment]
Comment 4 Mike Conley (:mconley) - (Needinfo me!) 2012-04-18 11:51:13 PDT
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/e1487fbcabfe
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/1c39ec381f69

Note You need to log in before you can comment on or make changes to this bug.