Closed Bug 746309 Opened 8 years ago Closed 8 years ago

Filelink uploads started from the offer notification bar has broken interaction

Categories

(Thunderbird :: Build Config, defect)

x86
Linux
defect
Not set

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

STR:

1)  Open a compose window, attach some files
2)  Choose to link the files, and create a new Filelink account with some provider

What happens?

The upload begins, but no notification bar comes up to tell us that links will be inserted into the body of the message.  What's more, the offer notification comes back up again.

What's expected?

The opposite of the above.
Ack, a typo slipped in to the patch for bug 738299.  I've found the issue - going to try to put together a test for it too.
Attached patch Patch v1Splinter Review
This fixes things, and I added a test.
Assignee: nobody → mconley
Attachment #615874 - Flags: review?(dbienvenu)
Comment on attachment 615874 [details] [diff] [review]
Patch v1

[Triage Comment]
Attachment #615874 - Flags: review?(dbienvenu)
Attachment #615874 - Flags: review+
Attachment #615874 - Flags: approval-comm-aurora+
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/e1487fbcabfe
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/1c39ec381f69
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.