Packager.pm doesn't correctly identify manifest files that contain more than one . (period)

NEW
Unassigned

Status

7 years ago
8 months ago

People

(Reporter: mossop, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Packager.pm uses fileparse to attempt to get the extension of files so that it can see if any are manifest files and so do special things with them. It passes the regex '\..*?$'. I assume that whoever wrote it made it non-greedy might have thought that meant it would only match everything from the last . onwards but it still matches anything from the first . so it thinks a file like "pdf.js.manifest" has the extension ".js.manifest". A better regex to use would be '\.[^\.]*$'. No idea how scary changing that is though.

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.