746360 - Throw a warning when clicking "Commit" if no bugs are selected on the "Edit multiple bugs at once" page

Status: REOPENED

(Bugzilla :: User Interface, enhancement)

Description

[David Marshall]

This is handy, but I don't have a patch to contribute, unfortunately.

It's easy to pull up edit-multiple, make some changes, and commit them without remembering to identify some bugs to change! Disable the "Commit" button unless some bugs are actually selected.

Comment 1

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Comment 2

[Frédéric Buclin]

Comment on attachment 785404 [details] [diff] [review]
Patch-v1

>-<input type="submit" id="commit" value="Commit">
>+<input type="submit" id="commit" value="Commit" disabled >

If JS is disabled, how do you commit changes as there is no way to re-enable the button?

Comment 3

[Frédéric Buclin]

Instead of disabling the Commit button, you should rather throw a message if no bugs are selected when clicking that button. If JS is disabled, then no message will be thrown and Bugzilla will still work as usual.

Comment 4

[Sunil Joshi [:sjoshi]]

This is WFM now.

With or Without javascript its displaying warning as "You apparently didn't choose any bugs to modify." when no checkboxes are checked.

Comment 5

[Frédéric Buclin]

(In reply to Sunil Joshi from comment #4)
> With or Without javascript its displaying warning as "You apparently didn't
> choose any bugs to modify." when no checkboxes are checked.

This is not a warning, this is an error, which is thrown *after* you submitted your changes. What is requested here is to throw a message before the form is submitted, so that you don't have to click the "Back" button (and potentially loose some data).