The getAssertion function exposed by the BrowserID identity has a complex argument structure that could be simplified further. For instance, since options and win are mutually exclusive, they can be merged to the same argument position.
Per discussion with Greg and Ben, a few improvements that we could make: - "audience" can be moved out to be a mandatory parameter, right after callback. - It is possible to make the "window" case be a separate function. So: getAssertion(callback, audience, [options]); getAssertionWithWindow(callback, audience, [options], [window]); and "options" can contain either "requiredEmail", or "sameEmailAs", but not both. I think this looks nice :)
I believe we agreed on a new API that makes this bug no longer relevant.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.