The default bug view has changed. See this FAQ.

Add unit tests for the alarm service

RESOLVED FIXED in 2.0

Status

Calendar
Alarms
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mmecca, Assigned: mmecca)

Tracking

unspecified

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 664922 [details] [diff] [review]
Fix v1

Alarm service unit tests
Attachment #664922 - Flags: review?(philipp)
Comment on attachment 664922 [details] [diff] [review]
Fix v1

Review of attachment 664922 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp, tests ftw!

::: calendar/test/unit/test_alarmservice.js
@@ +132,5 @@
> +
> +function createEventWithAlarm(aCalendar, aStart, aEnd, aOffset, aRRule) {
> +    let alarm = null;
> +    let item = cal.createEvent();
> +    

A few minor whitespace fixes here and elsewhere. Please also ensure your files have a newline at the end, so the diff doesn't complain with "No newline at and of file".
Attachment #664922 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

5 years ago
Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/95ecbcca7df6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.