746485 - [km] action items for fx 13

Status: RESOLVED FIXED

(Mozilla Localizations :: km / Khmer, defect)

Description

[Axel Hecht [:Pike]]

There are a few things missing and a few regressions in the latest landing http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/3de7a334f766 for fx 13.

First, you probably forgot to hg add and rm some files, see https://l10n-dev-sj.mozilla.org/dashboard/compare?run=210871:

The command for that would be

hg add browser/chrome/browser/devtools/debugger.dtd browser/chrome/browser/devtools/debugger.properties browser/chrome/browser/devtools/sourceeditor.dtd toolkit/chrome/global/resetProfile.dtd

hg rm browser/chrome/browser/scratchpad.properties

For the errors, https://l10n-dev-sj.mozilla.org/source/diff/?from=2563487d567b&to=3de7a334f766&repo=releases%2Fl10n%2Fmozilla-aurora%2Fkm:

There's an unreviewed change to region.properties, and the accesskeys dissappear again. The easiest way to fix those is to revert most of those files to the previous revision. I'd land this independently of the previous commit. You can push them in one, though. Manual fixing is needed for 

browser/chrome/browser/browser.properties, 
privateBrowsingYesTitle=&Start Private Browsing
privateBrowsingNoTitle=&Cancel
privateBrowsingNeverAsk=&Do not show this message again

dom/chrome/dom/dom.properties,
DontAskAgain

all have the '&' as accesskey again.

hg update -r 2563487d567b browser/chrome/browser/quitDialog.properties browser/chrome/browser-region/region.properties browser/installer/custom.properties browser/installer/mui.properties browser/installer/override.properties toolkit/chrome/global/commonDialogs.properties toolkit/chrome/passwordmgr/passwordmgr.properties toolkit/chrome/search/search.properties

You'll want to check the results with 

hg diff -u

to see that you're changing the right stuff, and then commit.

I also see a few strings getting untranslated, not sure if that's intended? Like, syncKey.dtd, security/manager/chrome/pipnss/pipnss.properties.

Comment 1

[Vannak Eng]

Actually i finished them all in Narro. it is 100% translated http://a.maimult.ro/lmo/project.php?l=km&p=28. when i exported it there was no error or missing string.

Comment 2

[Axel Hecht [:Pike]]

Hi Vannak, I see that you landed a good deal of these, great.

I see a few remaining one, most prominently, region.properties. That'd be 17/18 on page 2 of http://a.maimult.ro/lmo/translate.php?l=km&p=28&f=/browser/chrome/browser-region/region.properties&t=6&s=&o=0&h=1&m=10&i=0.

I still think that VerifiedTrue should be translated in http://a.maimult.ro/lmo/translate.php?l=km&p=28&f=/security/manager/chrome/pipnss/pipnss.properties&t=6&s=&o=0&h=1&m=10&i=0, I found your comment on the download folder, though, that should be fine.

Comment 3

[Vannak Eng]

so it is good to sign it off?

I couldn't find the remaining strings in the the two links you gave me.

Comment 4

[Axel Hecht [:Pike]]

Sadly, I can't give you links that don't suck in narro. You'll need to use the search feature on those pages to drill down to the entry. Search for yahoo in the region.properties link, and for true in pipnss.

Comment 5

[Vannak Eng]

So i should find those strings and translate them?

Comment 6

[Axel Hecht [:Pike]]

So, pipnss.properties got changed now, but now it ended up with windows line endings?

Re region.properties, the correct state is http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/file/291c003188fa/browser/chrome/browser-region/region.properties, there should be no difference to that.

Comment 7

[Vannak Eng]

Sorry, my bad i forget to change the line ending. I'll commit it again. Thanks

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Vannak Eng from comment #7)
> Sorry, my bad i forget to change the line ending. I'll commit it again.
> Thanks

On 24apr, I see landings in http://hg.mozilla.org/releases/l10n/mozilla-beta/km/ for the linux line endings. Is there anything left to do here, or can this bug be closed as FIXED?

Comment 9

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to John O'Duinn [:joduinn] from comment #8)
> (In reply to Vannak Eng from comment #7)
> > Sorry, my bad i forget to change the line ending. I'll commit it again.
> > Thanks
> 
> On 24apr, I see landings in
> http://hg.mozilla.org/releases/l10n/mozilla-beta/km/ for the linux line
> endings. Is there anything left to do here, or can this bug be closed as
> FIXED?

If we missed anything, please reopen with details.

Comment 10

[Axel Hecht [:Pike]]

Reopening 'til we have actually looked at things.

Comment 11

[Milos Dinic [:Milos]]

Vannak, John,

Thanks for this, it looks pretty good now. There's just one thing:

I can still see that you're going toward getting beta repositories in good shape for release, but as we mentioned earlier, we'll need Vannak keep and eye on aurora(that's a requirement for shipping final version of Firefox in Khmer), and have him working on it instead, as merges will do the rest. 

Anyhow, thanks for fixing this. Marking RESOLVED/FIXED.

Comment 12

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Milos Dinic [:Milos] from comment #11)
> Vannak, John,
> 
> Thanks for this, it looks pretty good now. 
Cool, thanks Milos.


> There's just one thing:
> 
> I can still see that you're going toward getting beta repositories in good
> shape for release, but as we mentioned earlier, we'll need Vannak keep and
> eye on aurora(that's a requirement for shipping final version of Firefox in
> Khmer), and have him working on it instead, as merges will do the rest. 
Agreed. From email with Vannak earlier this week, he's already got aurora fixes in narro and will get them merged into hg in the coming days.


> Anyhow, thanks for fixing this. Marking RESOLVED/FIXED.
Thanks again, this made my day!

Comment 13

[Vannak Eng]

Hi,
I just committed to hg. and wait for the update on repo.
Thanks