Comment 1 Andreas Nilsson (:andreasn) 2012-04-18 09:06:49 PDT

*** Bug 746596 has been marked as a duplicate of this bug. ***

Comment 2 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 12:39:07 PDT

Created attachment 616249 [details] [diff] [review]
WIP Patch v1

Comment 3 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 12:40:02 PDT

Andreas:

Depending on which lands first, this or bug 746307 - I think one of us is going to get bitrotted.

-Mike

Comment 4 Richard Marti (:Paenglab) 2012-04-18 13:17:20 PDT

You was faster :)

I think it would be better if you are using -moz-margin-end instead of margin-right. Then it works also for rtl languages.

I played only with:

#file-space-used,
#remaining-file-space {
  -moz-margin-start: 0.5ch;
}

but wasn't satisfied with the aligning of the text with the square.

When you use:

#provider-space label {
  -moz-margin-end: 0.5ch;
  vertical-align: middle;
}

#file-space-used,
#remaining-file-space {
  vertical-align: middle;
}

then the square could be better aligned with the text.
Instead of:

#file-space-used,
#remaining-file-space {

you could also use:

#provider-space span {

and then remove in .space-swatch the vertical-align: middle;

Comment 5 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:32:39 PDT

Created attachment 616268 [details] [diff] [review]
Patch v1

Screenshots are next.

Comment 6 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:33:15 PDT

Created attachment 616269 [details]
Ubuntu

Comment 7 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:42:04 PDT

Created attachment 616271 [details]
OSX

Comment 8 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:45:22 PDT

Created attachment 616273 [details]
Windows 7

Comment 9 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:47:49 PDT

Created attachment 616274 [details]
Windows XP

Comment 10 Mike Conley (:mconley) - (needinfo me!) 2012-04-18 13:49:06 PDT

Comment on attachment 616268 [details] [diff] [review]
Patch v1

Paenglab:

Awesome - thanks for the pointers!  Do I have the right idea, here?

-Mike

Comment 11 Richard Marti (:Paenglab) 2012-04-18 14:09:32 PDT

Comment on attachment 616268 [details] [diff] [review]
Patch v1

Yeah, this is what I thought. r+

Comment 12 Blake Winton (:bwinton) (:☕️) 2012-04-20 10:56:36 PDT

Comment on attachment 616268 [details] [diff] [review]
Patch v1

Based on the screenshots, it looks okay, but can someone tell me why we don't just add a space character to the end of cloudfileMgmt.usedSpace and cloudfileMgmt.unusedSpace in http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/cloudfile/management.dtd ?

Anyways, ui-r=me.

Thanks,
Blake.

Comment 13 Mike Conley (:mconley) - (needinfo me!) 2012-04-20 11:01:34 PDT

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #12)
> Comment on attachment 616268 [details] [diff] [review]
> Patch v1
> 
> Based on the screenshots, it looks okay, but can someone tell me why we
> don't just add a space character to the end of cloudfileMgmt.usedSpace and
> cloudfileMgmt.unusedSpace in
> http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/
> messenger/cloudfile/management.dtd ?

Mainly because of string freeze, but also, because the spacing thing is more about style / appearance (CSS) rather than content (the .dtd in this case).

That's how I think about it, anyhow.

> 
> Anyways, ui-r=me.
> 

Thanks!  :D

Comment 14 Mike Conley (:mconley) - (needinfo me!) 2012-04-20 11:48:27 PDT

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/71654bcf7870

Comment 15 Mike Conley (:mconley) - (needinfo me!) 2012-04-20 12:12:34 PDT

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/b166152a7dd4