Closed
Bug 746554
Opened 13 years ago
Closed 13 years ago
Dropbox and YouSendIt preference panes need margins next to used/unused storage counts
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(6 files, 1 obsolete file)
20.43 KB,
image/png
|
Details | |
5.92 KB,
patch
|
Paenglab
:
review+
bwinton
:
ui-review+
Bienvenu
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
63.07 KB,
image/png
|
Details | |
67.20 KB,
image/png
|
Details | |
70.11 KB,
image/png
|
Details | |
33.35 KB,
image/png
|
Details |
The used / unused storage storage counts seem pretty crammed together with their labels. Seems to be true on each platform. We should space those out.
See screenshot.
Assignee | ||
Comment 2•13 years ago
|
||
Assignee: nobody → mconley
Assignee | ||
Comment 3•13 years ago
|
||
Andreas:
Depending on which lands first, this or bug 746307 - I think one of us is going to get bitrotted.
-Mike
Blocks: 746307
Comment 4•13 years ago
|
||
You was faster :)
I think it would be better if you are using -moz-margin-end instead of margin-right. Then it works also for rtl languages.
I played only with:
#file-space-used,
#remaining-file-space {
-moz-margin-start: 0.5ch;
}
but wasn't satisfied with the aligning of the text with the square.
When you use:
#provider-space label {
-moz-margin-end: 0.5ch;
vertical-align: middle;
}
#file-space-used,
#remaining-file-space {
vertical-align: middle;
}
then the square could be better aligned with the text.
Instead of:
#file-space-used,
#remaining-file-space {
you could also use:
#provider-space span {
and then remove in .space-swatch the vertical-align: middle;
Assignee | ||
Comment 5•13 years ago
|
||
Screenshots are next.
Attachment #616249 -
Attachment is obsolete: true
Assignee | ||
Comment 6•13 years ago
|
||
Assignee | ||
Comment 7•13 years ago
|
||
Assignee | ||
Comment 8•13 years ago
|
||
Assignee | ||
Comment 9•13 years ago
|
||
Assignee | ||
Comment 10•13 years ago
|
||
Comment on attachment 616268 [details] [diff] [review]
Patch v1
Paenglab:
Awesome - thanks for the pointers! Do I have the right idea, here?
-Mike
Attachment #616268 -
Flags: ui-review?(bwinton)
Attachment #616268 -
Flags: review?(richard.marti)
Comment 11•13 years ago
|
||
Comment on attachment 616268 [details] [diff] [review]
Patch v1
Yeah, this is what I thought. r+
Attachment #616268 -
Flags: review?(richard.marti) → review+
Comment 12•13 years ago
|
||
Comment on attachment 616268 [details] [diff] [review]
Patch v1
Based on the screenshots, it looks okay, but can someone tell me why we don't just add a space character to the end of cloudfileMgmt.usedSpace and cloudfileMgmt.unusedSpace in http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/cloudfile/management.dtd ?
Anyways, ui-r=me.
Thanks,
Blake.
Attachment #616268 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Comment 13•13 years ago
|
||
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #12)
> Comment on attachment 616268 [details] [diff] [review]
> Patch v1
>
> Based on the screenshots, it looks okay, but can someone tell me why we
> don't just add a space character to the end of cloudfileMgmt.usedSpace and
> cloudfileMgmt.unusedSpace in
> http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/
> messenger/cloudfile/management.dtd ?
Mainly because of string freeze, but also, because the spacing thing is more about style / appearance (CSS) rather than content (the .dtd in this case).
That's how I think about it, anyhow.
>
> Anyways, ui-r=me.
>
Thanks! :D
Assignee | ||
Updated•13 years ago
|
Attachment #616268 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 14•13 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/71654bcf7870
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Updated•13 years ago
|
Attachment #616268 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 15•13 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/b166152a7dd4
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•