746564 - Replace 'request.locale' with 'request.LANGUAGE_CODE'

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[James Socol [:jsocol, :james]]

The Django docs[1] indicate that the built-in translation middleware (which we don't use) prefers 'request.LANGUAGE_CODE'. For compatibility with 3rd party apps (and to make a waffle upgrade possible) we should switch.

This if probably a big patch, but almost entirely search-and-replace, unless some lines need to be rewrapped.

[1] https://docs.djangoproject.com/en/1.3/topics/i18n/deployment/#how-django-discovers-translations

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

To clarify, is this something we should fix sooner rather than later, or is this something we can stick in the code quality pile to be fixed in an upcoming house-keeping week?

Comment 2

[Apokalyptica79]

Hello i would like to try this.

Thanks

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Let me know if you have any questions!

Comment 4

[Michał Frontczak [:fxa90id] ♥]

Can I pick it?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Michał Frontczak :fxa90id from comment #4)
> Can I pick it?

go for it :)

Comment 6

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/kitsune/pull/1121

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d3db15ec11cbb0ff26a2a179d83713c25229b97a

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Thanks Michał this was awesome!