746640 - Popup window.open() blocked when called from a key-related event listener

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Todd Kloots]

Attachment: popupblocker.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/534.55.3 (KHTML, like Gecko) Version/5.1.5 Safari/534.55.3

Steps to reproduce:

I'm adding keyboard shortcuts for an application. These shortcuts are for sharing news articles on Facebook, Twitter, etc. Each shortcut makes a call to window.open() to popup a window to the associated services sharing page.


Actual results:

The popup window initiated from the call to window.open() is blocked when called from a key-related (keypress, keydown, or keyup) event listener.




Expected results:

The popup window should not have been blocked in my opinion. The call to window.open() was initiated from a real user action. And Firefox doesn't block popups called from within a "click" event listener for example. So, it seems like they should not be blocked when called from within a key-related event listener.

Comment 1

[Todd Kloots]

One additional note: I've noticed that popup windows aren't blocked when the call to window.open() originates from a key event in Webkit.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

This should be an issue of DOM component.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: simplified testcase

And this is a simplified testcase shows that Firefox bans window.open in keypress event.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

FWIW, there is https://www.w3.org/TR/html5/browsers.html#allowed-to-show-a-popup in W3C spec, but I can't seem to find similar in HTML spec around https://html.spec.whatwg.org/#browsing-context-names

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

The list in WHATWG's HTML spec is https://html.spec.whatwg.org/multipage/interaction.html#triggered-by-user-activation and there is some discussion here: https://github.com/whatwg/html/issues/1903#issuecomment-260112697

Comment 6

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 8

[Zach Hoffman [:zrhoffman]]

Like bug 1863217, the bug 746640 testcase works after enabling dom.popup.experimental (enabled in Nightly as of bug 1911736).

Comment 9

[Edgar Chen [:edgar]]

Close per comment #8. Thanks for verifying this, Zach!

Comment 10

[Zach Hoffman [:zrhoffman]]

You bet!