746657 - Handle ENTER key special case during IME composition in GeckoInputConnection.onTextChanged()

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Keyboards and IME, defect, P4)

Description

[Chris Peterson [:cpeterson]]

> +            if (changedChar == '\n') {
> +                processKeyDown(KeyEvent.KEYCODE_ENTER, new KeyEvent(KeyEvent.ACTION_DOWN,
> +                                                                    KeyEvent.KEYCODE_ENTER), false);
> +                processKeyUp(KeyEvent.KEYCODE_ENTER, new KeyEvent(KeyEvent.ACTION_UP,
> +                                                                  KeyEvent.KEYCODE_ENTER), false);
> +                return;
> +            }

In GeckoInputConnection.onTextChanged(), the Enter key special case could run during composition. This may cause some bugs in nsEditor.

Masayuki thinks that the first |if| condition should be |changedText.length() == 1 && !hasCompositionString()|. Also, there may be cases when processKeyDown() causes onTextChange() to be reentered.

Comment 1

[Chris Peterson [:cpeterson]]

The ENTER key special case was added to fix bug 721393.

Comment 2

[Johnathan Nightingale [:johnath]]

cpeterson - can we get a clearer description on what this would break and how badly, so that we can triage it correctly?

Comment 3

[Chris Peterson [:cpeterson]]

I don't think this bug should be a blocker. This bug was just a reminder to clean up some IME code. There is no known misbehavior.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I was playing with the notion to get STRs.
1) go to http://people.mozilla.com/~nhirata/html_tp/NextAction_Bug614356.html
2) set IME to Simeji
3) click in First name field
4) type in hira without committing (ie hitting return)
5) click on the last name field
6) hit return

Expected: clicking on the last name field will commit the first name, hitting return will go to the next field
Actual: hitting return commits what was typed in the first name field in the last name field as well.

Comment 5

[Chris Peterson [:cpeterson]]

nhirata, I think you have found a different bug. Can you open a new bug for that issue? Also, replace your step #6 with "enter more characters after clicking input focus to 'Last name' field" then the uncommitted composition string from "First name" will continue will in "Last name".

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.