Give Filelink notification toggle and spinner a bit more bottom margin

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
x86
Windows 7
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(5 attachments, 2 obsolete attachments)

Created attachment 616277 [details]
Notice how the toggle / spinner crowded everything else a bit

The toggle and spinner seem to crowd in a bit with both the menulist and the management pane for a selected provider.  We might want to give the toggle / spinner more bottom margin.

See attachment.
(Assignee)

Comment 1

5 years ago
I'm not sure what you mean needs more bottom margin. Is it the richlistitem with the Dropbox-/Yousendit icon? If yes, I checked with DOMi and it looks correct aligned.

The paper flyer (is it that?) of the YSI icon isn't centered on the icon. So this could give the impression of a to low positioned icon.
Hey Richard,

Sorry - I wasn't clear.

I'm talking about both the richlist, and the large "Dropbox" title. Both seem to be a little bit close to the offer toggle and number spinner that are above them.

It doesn't make the UI unusable or unreadable by any means - it's mostly just an aesthetic thing.  It *feels* crowded.

Know what I mean?

-Mike
(Assignee)

Comment 3

5 years ago
Created attachment 616686 [details] [diff] [review]
Patch

I gave a padding-bottom of 6px. On top the tabpanels has a padding of 8px. On bottom the richlistbox has a margin of 2px. With this the cloudFileToggleAndThreshold box should be correctly centered.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #616686 - Flags: review?(mconley)
Comment on attachment 616686 [details] [diff] [review]
Patch

Review of attachment 616686 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Paenglab,

Thanks for tackling this. :) A few things:

1)  I think this is a problem on OSX too, so we'll likely need something for pinstripe.  gnomestripe might be OK.
2)  I'm getting scrollbars in the management pane with this patch.  I wonder if Andreas's work in bug 746307 might help here - I think it axes some of our hardcoded dimensions.

-Mike
Attachment #616686 - Flags: review?(mconley) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 616722 [details] [diff] [review]
Patch v2

> Review of attachment 616686 [details] [diff] [review]:
> 
> 1)  I think this is a problem on OSX too, so we'll likely need something for
> pinstripe.  gnomestripe might be OK.

I checked before pinstripe and gnomestripe. On OSX I thought it looked okay without change. This is also why I now only added 3px. Linux has a bottom padding of 15px which maybe is a little bit to much. With a bottom padding of 6px it would also be centered like on Windows. Should I do this?

> 2)  I'm getting scrollbars in the management pane with this patch.  I wonder
> if Andreas's work in bug 746307 might help here - I think it axes some of
> our hardcoded dimensions.

First I had Lightning enabled and saw no scrollbars. I tested with the rules of the patch of bug 746307 and the scrollbars disappeared also with Lightning disabled.

If this patch becomes r+ we could wait for bug 746307 to land this.
Attachment #616686 - Attachment is obsolete: true
Attachment #616722 - Flags: review?(mconley)
Depends on: 746307
Created attachment 617066 [details]
Side-by-side comparison on Windows 7

Original is on the left, patches applied is on the right.
Created attachment 617071 [details]
Side-by-side on OSX

Same as above, except on OSX.
Comment on attachment 616722 [details] [diff] [review]
Patch v2

Blake - thoughts?
Attachment #616722 - Flags: ui-review?(bwinton)
Comment on attachment 616722 [details] [diff] [review]
Patch v2

Hey Richard,

Code looks good - I think I want a little more margin on OSX, though.  Can we double it to 6px from 3px?

Note that when we do that, the link at the bottom to go to each provider's website will be too low, and will need to be adjusted accordingly (unless Andreas's patch takes care of that when he makes one for OSX...because it might).

-Mike
Attachment #616722 - Flags: ui-review?(bwinton)
Attachment #616722 - Flags: ui-review-
Attachment #616722 - Flags: review?(mconley)
Attachment #616722 - Flags: review+
(Assignee)

Comment 10

5 years ago
Created attachment 617098 [details] [diff] [review]
Patch v3

Only change: gave OSX a padding-bottom of 6px.

With Andreas's patch applied the link on bottom jumps beside the graphic.  So I don't change anything there.

Carrying over the r+
Attachment #616722 - Attachment is obsolete: true
Attachment #617098 - Flags: ui-review?(mconley)
Attachment #617098 - Flags: review+
(Assignee)

Comment 11

5 years ago
Created attachment 617099 [details]
Screenshot showing there the link goes

Screenshot on Win7 with the patch from bug 746307 applied. The link is now beside the graphic. I suppose the same happens on Mac but I can't set up a Filelink provider on my Mac VM to check this.
Thanks Richard.  Just going to wait for bug 746307 to stabilize before testing this.
Comment on attachment 617098 [details] [diff] [review]
Patch v3

With Andreas's patch for bug 746307 landed, I tried this out, and the link didn't seem to move around like in your screenshot.

It looked awesome.  So I'm ui-r+'ing this.

Thanks Richard,

-Mike
Attachment #617098 - Flags: ui-review?(mconley) → ui-review+
Attachment #617098 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #617098 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/c074ae4d363e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/07480ef159ca
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.