74680 - Choosing the same charset as the webpage is already presented in shouldn't reload the page

Status: RESOLVED WONTFIX

(Core :: Internationalization, defect, P4)

Description

[Henrik Gemal]

If you go to:
http://contactel.sprawl.dk/
and check the View -> Char Code it's set to Centrael Europe
If the user selects View -> Char Code -> Centrael Europe

Mozilla shouldn't reload the page

Comment 1

[nhottanscp]

Reassign to jbetak.

Comment 2

[[e-mail] (away - not reading bugmail)]

accepting

Comment 3

[[e-mail] (away - not reading bugmail)]

Attachment: Preliminary patch

Comment 4

[[e-mail] (away - not reading bugmail)]

Attachment: cvs diff -u -b -w .\xpfe\browser\resources\content\navigator.js

Comment 5

[[e-mail] (away - not reading bugmail)]

Naoki, could you please help me with yet another review? 

It's virtually the same stuff like in bug 60406. I was somewhat concerned about 
performance, but this only gets executed, when manually overriding a charset, 
not when e.g. reloading a page. I think we should be fine...

Comment 6

[nhottanscp]

Did you test with many cases (META, HTTP server, frame, etc.)?
I think we do not need to fix this unless we are sure about no regression with 
the patch.

Comment 7

[[e-mail] (away - not reading bugmail)]

Naoki,

I did fair amount of testing and I'm quite certain about the implications. This 
event handler gets executed only when there is manual user interaction in the 
Charset Menu. Basically it's just for charset override. It would also give 
Mozilla an edge over IE, since they do a reload when you try to override the 
current charset with the same thing manually.

Comment 8

[nhottanscp]

But please test with frame cases where a page contains multiple frames in
different charsets. Make sure you do not use a parent charset when the user is
trying to change a charset of a particular frame.

Comment 9

[[e-mail] (away - not reading bugmail)]

will do. BTW do we have a set of test pages somewhere? Am I correct in assuming 
that frame-specific override will be achieved via the context (right-mouse-
button) menu?

Comment 10

[[e-mail] (away - not reading bugmail)]

reassign to nhotta 

Comment 11

[nhottanscp]

I realized that that's not implemented (bug 63054).
So no way to test.

The patch looks fine but I am not comfortable checking in now, and the reload
issue is not critical for 0.9.1.

Comment 12

[Henrik Gemal]

this really must be easy to fix. Something about:
newcharset != oldcharset then reload()

Comment 13

[Henri Sivonen (:hsivonen)]

Telemetry shows that this feature is used extremely rarely. It is not worthwhile to polish this feature further.