746937 - Submit mobile nightly builds to balrog

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Rail Aliiev [:rail]]

Once bug 743304 is fixed we'll need to adjust automation so it submits android updates to balrog. In staging it fails right now:

Executing: ['/tools/python-2.6.5/bin/python', '/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin-dev.allizom.org', '--verbose', '--credentials-file', 'BuildSlaves.py']
Traceback (most recent call last):
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py", line 36, in <module>
    runner.run()
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/cli.py", line 71, in run
    blob = self.generate_blob()
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/cli.py", line 54, in generate_blob
    'filesize': props['completeMarSize'],
KeyError: 'completeMarSize'

Comment 1

[[e-mail] (:bhearsum)]

We're going to want this for our next milestone.

Comment 2

[[e-mail] (:bhearsum)]

This seems like it's because Mobile builds create snippets through android_snippet.py rather than the factory logic, and thus never get the properties set. Sounds like we should get the required properties returned back to Buildbot. In the glorious mozharness future this would probably all be handled within a mozharness script, which would be able to keep track of this sort of information.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: raise properties to buildbot; add android update platforms

This, plus the incoming buildbotcustom patch, gets us raising properties up to buildbot so that the balrog submission script can submit data to the server. We also need add entries to the update platform map, otherwise we end up with platforms like 'android' or 'android-x86'. I didn't bother adding noion because I'm pretty sure that's on the verge of extinction.

With these patches you can use fake URLs to get results, eg:
http://dev-master01.build.scl1.mozilla.com:8000/update/3/Fennec/22.0a1/20130126143652/Android_arm-eabi-gcc3/en-US/nightly/4.1.1/default/default/update.xml

We still need additional work, probably done elsewhere, before we support the real URL schema that Android users (/update/4/...)

Aki, I figured you were the best person to review the android-snippet.py changes. Nick, I think we said yesterday that we could support additional URL schemas without adding new blob formats - am I remembering correctly? I suppose we can still change things later if we decide that it doesn't work.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: factory changes to set properties

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 730763 [details] [diff] [review]
raise properties to buildbot; add android update platforms

Oops, I meant to tag Nick here too.

Comment 6

[[e-mail] (:bhearsum)]

in production