Submit mobile nightly builds to balrog

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
7 years ago
5 months ago

People

(Reporter: rail, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [balrog][mobile])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Once bug 743304 is fixed we'll need to adjust automation so it submits android updates to balrog. In staging it fails right now:

Executing: ['/tools/python-2.6.5/bin/python', '/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py', '--build-properties', 'buildprops_balrog.json', '--api-root', 'https://aus4-admin-dev.allizom.org', '--verbose', '--credentials-file', 'BuildSlaves.py']
Traceback (most recent call last):
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/scripts/updates/balrog-client.py", line 36, in <module>
    runner.run()
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/cli.py", line 71, in run
    blob = self.generate_blob()
  File "/builds/slave/m-cen-andrd-xul-ntly/tools/lib/python/balrog/client/cli.py", line 54, in generate_blob
    'filesize': props['completeMarSize'],
KeyError: 'completeMarSize'

Updated

7 years ago
Priority: -- → P3
(Assignee)

Updated

7 years ago
Blocks: 583244
(Assignee)

Comment 1

6 years ago
We're going to want this for our next milestone.
Blocks: 832454
No longer blocks: 583244
(Assignee)

Comment 2

6 years ago
This seems like it's because Mobile builds create snippets through android_snippet.py rather than the factory logic, and thus never get the properties set. Sounds like we should get the required properties returned back to Buildbot. In the glorious mozharness future this would probably all be handled within a mozharness script, which would be able to keep track of this sort of information.
(Assignee)

Updated

6 years ago
Assignee: nobody → bhearsum
(Assignee)

Comment 3

6 years ago
Created attachment 730763 [details] [diff] [review]
raise properties to buildbot; add android update platforms

This, plus the incoming buildbotcustom patch, gets us raising properties up to buildbot so that the balrog submission script can submit data to the server. We also need add entries to the update platform map, otherwise we end up with platforms like 'android' or 'android-x86'. I didn't bother adding noion because I'm pretty sure that's on the verge of extinction.

With these patches you can use fake URLs to get results, eg:
http://dev-master01.build.scl1.mozilla.com:8000/update/3/Fennec/22.0a1/20130126143652/Android_arm-eabi-gcc3/en-US/nightly/4.1.1/default/default/update.xml

We still need additional work, probably done elsewhere, before we support the real URL schema that Android users (/update/4/...)

Aki, I figured you were the best person to review the android-snippet.py changes. Nick, I think we said yesterday that we could support additional URL schemas without adding new blob formats - am I remembering correctly? I suppose we can still change things later if we decide that it doesn't work.
Attachment #730763 - Flags: review?(aki)
(Assignee)

Comment 4

6 years ago
Created attachment 730764 [details] [diff] [review]
factory changes to set properties
Attachment #730764 - Flags: review?(aki)

Updated

6 years ago
Attachment #730763 - Flags: review?(aki) → review+

Updated

6 years ago
Attachment #730764 - Flags: review?(aki) → review+
(Assignee)

Comment 5

6 years ago
Comment on attachment 730763 [details] [diff] [review]
raise properties to buildbot; add android update platforms

Oops, I meant to tag Nick here too.
Attachment #730763 - Flags: review?(nthomas)
Attachment #730763 - Flags: review?(nthomas) → review+
(Assignee)

Updated

6 years ago
Attachment #730764 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Attachment #730763 - Flags: checked-in+
(Assignee)

Comment 6

6 years ago
in production
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.