746938 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoNetworkManager.getNetworkType(GeckoNetworkManager.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There are four crashes so far, the latest one in 14.0a1/20120414: bp-9a3a7822-e6b4-4a91-b084-0e82b2120419.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoNetworkManager.getNetworkType(GeckoNetworkManager.java:226)
	at org.mozilla.gecko.GeckoNetworkManager.updateNetworkType(GeckoNetworkManager.java:183)
	at org.mozilla.gecko.GeckoNetworkManager.start(GeckoNetworkManager.java:158)
	at org.mozilla.gecko.GeckoApp.onApplicationResume(GeckoApp.java:2147)
	at org.mozilla.gecko.GeckoApplication.onActivityResume(GeckoApplication.java:55)
	at org.mozilla.gecko.GeckoActivity.onResume(GeckoActivity.java:33)
	at org.mozilla.gecko.GeckoApp.onResume(GeckoApp.java:1987)
	at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1154)
	at android.app.Activity.performResume(Activity.java:4539)
	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2434)
	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2472)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1173)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoNetworkManager.getNetworkType%28GeckoNetworkManager.java%29

Comment 1

[Aaron Train [:aaronmt]]

Ethernet?

http://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoNetworkManager.java#226

Comment 2

[Geoff Brown [:gbrown]]

I do not understand what is going wrong here, but we can be more careful about checking for null in getNetworkType.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: check for null returns from system calls in getNetworkType

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 625688 [details] [diff] [review]
check for null returns from system calls in getNetworkType

Review of attachment 625688 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoNetworkManager.java
@@ +193,5 @@
>  
> +    NetworkInfo ni = cm.getActiveNetworkInfo();
> +
> +    if (ni == null) {
> +      Log.w("GeckoNetworkManager", "Could not get network info");

No need to warn: this is expected when offline IIRC.

Comment 5

[Geoff Brown [:gbrown]]

Attachment: check for null returns from system calls in getNetworkType

Extra warning removed as per review comment.

r=mounir carried.

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9463528f5c09

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9463528f5c09

Comment 8

[Scoobidiver (away)]

It's #111 top crasher in 14.0b3.

Comment 9

[Mounir Lamouri (:mounir)]

It is marked as fixed in Firefox 15 so it isn't surprising to be still visible in Firefox 14, right?

Comment 10

[Scoobidiver (away)]

There are still crashes in 15.0a2.

Comment 11

[Geoff Brown [:gbrown]]

(In reply to Scoobidiver from comment #10)
> There are still crashes in 15.0a2.

Oh no -- I patched the wrong file!! 

I updated embedding/android/GeckoNetworkManager.java instead of mobile/android/base/GeckoNetworkManager.java.

Comment 12

[Geoff Brown [:gbrown]]

Attachment: check for null returns from system calls in getNetworkType - native!

Same as the previously landed patch, but applied to the native Fennec version of GeckoNetworkManager.

Comment 13

[Mounir Lamouri (:mounir)]

Comment on attachment 634999 [details] [diff] [review]
check for null returns from system calls in getNetworkType - native!

Review of attachment 634999 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the changes listed below.

::: mobile/android/base/GeckoNetworkManager.java
@@ +187,5 @@
>      ConnectivityManager cm =
>        (ConnectivityManager)GeckoApp.mAppContext.getSystemService(Context.CONNECTIVITY_SERVICE);
>  
> +    if (cm == null) {
> +      Log.w("GeckoNetworkManager", "Could not access Connectivity service");

According to the docs [1], the value returned is "The service or null if the name does not exist.". So, I would suggest to switch to an error (because we expect it to exist, right?) and update the message accordingly.

[1] http://developer.android.com/reference/android/content/Context.html#getSystemService(java.lang.String)

@@ +192,5 @@
>        return NetworkType.NETWORK_NONE;
>      }
>  
> +    NetworkInfo ni = cm.getActiveNetworkInfo();
> +

nit: Could you remove that empty line?

@@ +215,5 @@
>      TelephonyManager tm =
>        (TelephonyManager)GeckoApp.mAppContext.getSystemService(Context.TELEPHONY_SERVICE);
>  
> +    if (tm == null) {
> +      Log.w("GeckoNetworkManager", "Could not access Telephony service");

Same as above: should probably be an error and the message should be updated.

Comment 14

[Geoff Brown [:gbrown]]

Attachment: check for null returns from system calls in getNetworkType - native!

Updated for review comments - thanks! r=mounir

Comment 15

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ec957ae5ffd

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8ec957ae5ffd