OSX XULRunner SDKs aren't getting named properly

RESOLVED FIXED in mozilla14

Status

Toolkit Graveyard
XULRunner
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla14
All
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 734975 shouldn't have changed the name of the SDKs built by universal builds, we should still get the two SDKs:

xulrunner-14.0a1.en-US.mac-i386.sdk.tar.bz2
xulrunner-14.0a1.en-US.mac-x86_64.sdk.tar.bz2

but apparently we are just getting:

xulrunner-14.0a1.en-US.mac.sdk.tar.bz2
(Assignee)

Comment 1

6 years ago
Created attachment 616773 [details] [diff] [review]
patch rev 1

Embed the cpu info into the SDK filename in universal builds. Confirmed that this produces the right names in my local build.
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Attachment #616773 - Flags: review?(benjamin)

Updated

6 years ago
Attachment #616773 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

6 years ago
Comment on attachment 616773 [details] [diff] [review]
patch rev 1

Without this we aren't going to be building the necessary SDKs for building XPCOM components on OSX. Risk is low, it's build config so any issues should reveal themselves immediately after checkin.
Attachment #616773 - Flags: approval-mozilla-central?
Attachment #616773 - Flags: approval-mozilla-central? → approval-mozilla-central+
(Assignee)

Comment 3

6 years ago
This landed a few weeks ago: http://hg.mozilla.org/mozilla-central/rev/85abf12e5c83
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.