Closed Bug 747018 Opened 8 years ago Closed 7 years ago

Download widget stylesheets applied twice to browser.xul (chrome://browser/content/downloads/downloads.css as well as chrome://browser/skin/downloads/downloads.css)

Categories

(Firefox :: Downloads Panel, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: dao, Assigned: Paolo)

References

Details

(Keywords: perf)

Attachments

(1 file)

For some reason, chrome://browser/content/downloads/downloads.css as well chrome://browser/skin/downloads/downloads.css are loaded twice.
OS: Windows 7 → All
Hardware: x86_64 → All
Component: General → Downloads Panel
QA Contact: general → downloads.panel
(In reply to Dão Gottwald [:dao] from comment #0)
> For some reason, chrome://browser/content/downloads/downloads.css as well
> chrome://browser/skin/downloads/downloads.css are loaded twice.

It looks like the overlay code is not smart enough to notice that we are loading
the same CSS files from two overlays, the one of the indicator and the one of the
panel.

So, either we split the CSS in two files, one for the indicator and one for the
panel, or we rewrite the loading process to ensure that the indicator overlay is
always loaded before the panel overlay, and keep the CSS in the indicator overlay
only.
No longer blocks: DownloadsPanel
Marco says we can simplify this when we drop support for the old downloads UI.
Depends on: 845403
Attached patch The patchSplinter Review
This separates the indicator and panel stylesheets, fixing the duplicate rules.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #768299 - Flags: review?(mak77)
Attachment #768299 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/0157ae36ac47
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.