747018 - Download widget stylesheets applied twice to browser.xul (chrome://browser/content/downloads/downloads.css as well as chrome://browser/skin/downloads/downloads.css)

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Dão Gottwald [:dao]]

For some reason, chrome://browser/content/downloads/downloads.css as well chrome://browser/skin/downloads/downloads.css are loaded twice.

Comment 1

[:Paolo Amadini]

(In reply to Dão Gottwald [:dao] from comment #0)
> For some reason, chrome://browser/content/downloads/downloads.css as well
> chrome://browser/skin/downloads/downloads.css are loaded twice.

It looks like the overlay code is not smart enough to notice that we are loading
the same CSS files from two overlays, the one of the indicator and the one of the
panel.

So, either we split the CSS in two files, one for the indicator and one for the
panel, or we rewrite the loading process to ensure that the indicator overlay is
always loaded before the panel overlay, and keep the CSS in the indicator overlay
only.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Marco says we can simplify this when we drop support for the old downloads UI.

Comment 3

[:Paolo Amadini]

Attachment: The patch

This separates the indicator and panel stylesheets, fixing the duplicate rules.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0157ae36ac47