Last Comment Bug 747102 - kSmallCommit shouldn't be used, since it doesn't do anything.
: kSmallCommit shouldn't be used, since it doesn't do anything.
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Database (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 14.0
Assigned To: David :Bienvenu
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-19 11:36 PDT by David :Bienvenu
Modified: 2012-04-23 16:10 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
proposed fix (3.79 KB, patch)
2012-04-19 12:08 PDT, David :Bienvenu
neil: review+
Details | Diff | Splinter Review
patch for removing SmallCommit() (3.38 KB, patch)
2012-04-20 13:08 PDT, :aceman
mozilla: review+
Details | Diff | Splinter Review
patch for removing SmallCommit() v2 (4.38 KB, patch)
2012-04-23 11:41 PDT, :aceman
mozilla: review+
Details | Diff | Splinter Review

Description David :Bienvenu 2012-04-19 11:36:49 PDT
nsIMsgDatabase::kSmallCommit doesn't do anything in mork, so it shouldn't be used, since it's a temptation.
Comment 1 David :Bienvenu 2012-04-19 12:08:01 PDT
Created attachment 616687 [details] [diff] [review]
proposed fix
Comment 2 neil@parkwaycc.co.uk 2012-04-19 12:26:28 PDT
Comment on attachment 616687 [details] [diff] [review]
proposed fix

(I don't think changing the uuids has any effect, because nobody QIs to them.)
Comment 3 :aceman 2012-04-19 14:42:02 PDT
What about the SmallCommit() method that was called as a result of choosing kSmallCommit? Is that still used/needed?
Comment 4 David :Bienvenu 2012-04-19 15:20:55 PDT
(In reply to :aceman from comment #3)
> What about the SmallCommit() method that was called as a result of choosing
> kSmallCommit? Is that still used/needed?

I don't care so much about the mork method since people are much less likely to try to call that. But it can go away as well from db/mdb and db/mork
Comment 5 :aceman 2012-04-19 23:56:03 PDT
Can I do it here or in a new bug?
Comment 6 David :Bienvenu 2012-04-20 07:54:26 PDT
(In reply to :aceman from comment #5)
> Can I do it here or in a new bug?

doing it here is fine...
Comment 7 David :Bienvenu 2012-04-20 07:57:50 PDT
db and addrbook patch landed here - http://hg.mozilla.org/comm-central/rev/52160eb9efd5
Comment 8 :aceman 2012-04-20 13:08:59 PDT
Created attachment 617075 [details] [diff] [review]
patch for removing SmallCommit()
Comment 9 David :Bienvenu 2012-04-23 11:18:34 PDT
Comment on attachment 617075 [details] [diff] [review]
patch for removing SmallCommit()

can you rev the IID on nsIMdbStore while you're at it? I doubt anyone cares, but technically, we should.
Comment 10 :aceman 2012-04-23 11:41:01 PDT
Created attachment 617563 [details] [diff] [review]
patch for removing SmallCommit() v2

Like this?
Comment 11 David :Bienvenu 2012-04-23 11:42:05 PDT
Comment on attachment 617563 [details] [diff] [review]
patch for removing SmallCommit() v2

Review of attachment 617563 [details] [diff] [review]:
-----------------------------------------------------------------

yes, thx.
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-04-23 16:10:23 PDT
http://hg.mozilla.org/comm-central/rev/33e93567f9f3

Note You need to log in before you can comment on or make changes to this bug.