Marketplace reviewer emails should not be double escaped

RESOLVED FIXED in 6.5.2

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: cvan, Assigned: robhudson)

Tracking

unspecified
6.5.2

Details

(Reporter)

Description

6 years ago
Notice the ' which should be ' in this email:

You have products at the Mozilla Marketplace that have pending refund requests and require your attention.  Please visit the URLs below to respond to these requests:

   XXX SeaVan's Undersea Adventure: Down Under (1 request)
   https://addons-dev.allizom.org/developers/app/xasdfasdf/refunds

Thanks for your prompt response.  Your customers will appreciate it!

- the Mozilla Marketplace Team
(Reporter)

Comment 1

6 years ago
Also it says addons-dev it should be marketplace-dev
(Assignee)

Comment 2

6 years ago
Our email code is a bit of a mess and uses different flags in varying places.

Variations I've seen:
* Using Django templates with `autoescape` not specified (defaults to being on) (bad)
* Using Django templates with `autoescape` set to False (good).
* Using Jinja templates with autoescaping off (best).

I'd like to move everything to jinja and autoescaping off. Jinja allows us to use the whitespace stripping template tags so we don't have to worry about newlines all over our emails.

I set this up in mkt reviewers but it needs to be centralized and used in our codebase.
(Reporter)

Updated

6 years ago
Assignee: nobody → cvan
Target Milestone: --- → 6.5.2
(Assignee)

Comment 3

6 years ago
https://github.com/mozilla/zamboni/commit/853c1f3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Assignee: cvan → robhudson.mozbugs
(Assignee)

Comment 4

6 years ago
Follow-up commit:
https://github.com/mozilla/zamboni/commit/f0ae64f4
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.