747163 - TelemetryHistogramType returns failure for HISTOGRAM_FLAG

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Comment 1

[Graeme McCutcheon [:graememcc]]

Attachment: v1

...and here's why!

Comment 2

[(dormant account)]

Comment on attachment 616736 [details] [diff] [review]
v1

This needs Telemetry.histogramFrom testcase added for a flag histogram. I'm guessing you stumbled upon this because it caused an error on startup?

Comment 3

[Graeme McCutcheon [:graememcc]]

Attachment: With tests

> I'm guessing you stumbled upon this because it caused an error on startup?

I added a telemetry flag in bug 724513, which had "cache" in the description, which caused it to get picked up by gatherStartupInfo in TelemetryPing.js, so test_TelemetryPing started failing in the histogramFrom/TelemetryHistogramType call.

I've added a test to exercise histogramFrom for all types, however it uncovered bug 747379. Bugs all the way down!

Comment 4

[(dormant account)]

Comment on attachment 616988 [details] [diff] [review]
With tests

Graeme, I only see additional implicit {} moving around in this patch, are you sure that's the right patch?

Comment 5

[(dormant account)]

Comment on attachment 616988 [details] [diff] [review]
With tests

nm. r+ with pointless {} changes undone.

Comment 6

[Graeme McCutcheon [:graememcc]]

Not sure how those brace changes got in there. I probably thought I'd added them when debugging the test failure that became 747379.

Anyway, https://hg.mozilla.org/integration/mozilla-inbound/rev/304cd5d5124b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ce462a9693d