TelemetryHistogramType returns failure for HISTOGRAM_FLAG

RESOLVED FIXED in mozilla15

Status

()

Toolkit
Telemetry
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: graememcc, Assigned: graememcc)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.98 KB, patch
(dormant account)
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 616736 [details] [diff] [review]
v1

...and here's why!
Attachment #616736 - Flags: review?(taras.mozilla)

Comment 2

5 years ago
Comment on attachment 616736 [details] [diff] [review]
v1

This needs Telemetry.histogramFrom testcase added for a flag histogram. I'm guessing you stumbled upon this because it caused an error on startup?
Attachment #616736 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 616988 [details] [diff] [review]
With tests

> I'm guessing you stumbled upon this because it caused an error on startup?

I added a telemetry flag in bug 724513, which had "cache" in the description, which caused it to get picked up by gatherStartupInfo in TelemetryPing.js, so test_TelemetryPing started failing in the histogramFrom/TelemetryHistogramType call.

I've added a test to exercise histogramFrom for all types, however it uncovered bug 747379. Bugs all the way down!
Attachment #616736 - Attachment is obsolete: true
Attachment #616988 - Flags: review?(taras.mozilla)

Comment 4

5 years ago
Comment on attachment 616988 [details] [diff] [review]
With tests

Graeme, I only see additional implicit {} moving around in this patch, are you sure that's the right patch?

Comment 5

5 years ago
Comment on attachment 616988 [details] [diff] [review]
With tests

nm. r+ with pointless {} changes undone.
Attachment #616988 - Flags: review?(taras.mozilla) → review+
(Assignee)

Updated

5 years ago
Blocks: 724513
(Assignee)

Comment 6

5 years ago
Not sure how those brace changes got in there. I probably thought I'd added them when debugging the test failure that became 747379.

Anyway, https://hg.mozilla.org/integration/mozilla-inbound/rev/304cd5d5124b
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/7ce462a9693d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.